Allowing placement policies to work with Dynamic Nodesets #4369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the auto-generated placement policy name in the
`schedmd-slurm-gcp-v6-nodeset-dynamic` module to include the
`slurm_cluster_name`.
This change addresses feedback to ensure that default placement policy
names are unique across different Slurm cluster deployments within the
same Google Cloud project.
The new default format for the policy name is:
`{slurm_cluster_name}-{nodeset_name}-compact-policy`
If you provide a custom `placement_policy_name`, that will still
take precedence.
cboneti
added
the
release-bugfix
SwarnaBharathiMantena
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.