-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat: add Clear History option in Settings #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm really impressed with your work. This is the highest quality PR I've received. Just so you know, since the app is commercially availaible on the Microsoft Store and soon the Apple Store, I will have to make you sign some form of CLA. Thank you again! |
Thanks. It's just a small contribution but I think some can appreciate the feature. Please provide me the CLA to sign it. |
Signed |
Hey @Jor-Tech, I left a comment, if you could amend your PR. Thank you! |
@Fredolx where can I find your comment I don't see it? |
Here's a link to it @Jor-Tech |
Sorry, I really want to follow up on your comment, but the link you point to doesn't work for me, and when I got to the "Files changed" tab I also don't find any comments on the code. |
I will copy paste the comment In You forgot to commit the css class .history, the svg does not show. Also the tooltip is unnecessary. You can remove it. |
Thanks, updated the PR with the requested changes in your comment. |
I reviewed a bit the look and there's a few final touch-ups to make. To match the rest of the UI, move the new button before "Delete everything" so it makes sense logically. Then also change it from btn-warning to btn-secondary so that the color of the text is also white. After that we should be ready to merge. |
Do you mind white text on yellow button, prefer to have the button style exactly the same as the "Refresh all" button (white text on grey button), or make it black text on yellow button like before? Personally I would go with the latter, but up to you of course. Let me know. |
white text on yellow button looks quite ugly, so I prefer the button to be secondary |
Agree, that's why I thought black on yellow. But if you prefer I'll make it secondary like the "Refresh all" button. |
Yes make it secondary like the refresh btn next to it |
Everything is perfect except one thing, please remove all your changes from I only modify this file when I do a release. I'm not ready for a release this week |
Got it. Removed it from the "change log" whats-new-modal.component.html |
Thank you for your contribution. If you are interested in more work, I can open up a kanban board from which you could choose features you'd like to work on. There's a few features that could be implemented/improved. Stalker supports needs to be investigated, and the catchup feature needs to be more stable. |
Sure, I can take a look at the kanban board to see if there is anything I can help with and work on. |
Adds a new “Clear History” button to the Settings screen, letting users instantly erase their watch/viewing history. When tapped, the button prompts for confirmation and then clears all stored history entries. This enhancement gives users direct control over their privacy and data with a single, easy-to-find action in the app’s settings.