Allow running tool on latest&greatest #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's highly unlikely that a future vesion of the dotnet runtime will break things so fundamentally that the Ulid CLI would fail. Therefore, rather than failing to start as time goes by and new versions of dotnet become prevalent and the current ones targeted by the project become obsolete, let the tool run on whatever version the user has (latest major even). This setting (for example) would have allowed the existing published build targeting the STS .net7 to run on .net8 or even .net9/10 soon, without any issues. As it is now, however, users get an error instead: ``` pwsh> dotnet ulid You must install or update .NET to run this application. App: C:\Users\[user]\.dotnet\tools\dotnet-ulid.exe Architecture: x64 Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64) .NET location: C:\Program Files\dotnet\ The following frameworks were found: 6.0.36 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 8.0.16 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] 9.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Learn more: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=win-x64&os=win10 ``` Which is quite a bad user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's highly unlikely that a future vesion of the dotnet runtime will break things so fundamentally that the Ulid CLI would fail. Therefore, rather than failing to start as time goes by and new versions of dotnet become prevalent and the current ones targeted by the project become obsolete, let the tool run on whatever version the user has (latest major even).
This setting (for example) would have allowed the existing published build targeting the STS .net7 to run on .net8 or even .net9/10 soon, without any issues.
As it is now, however, users get an error instead:
Which is quite a bad user experience.