-
Notifications
You must be signed in to change notification settings - Fork 282
Transition improvements and additions #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
-depends on CasparCG#1615 -improved auto_play_delta for all transitions so that the last frame of a producer is displayed on the last visible frame of the transition -modified audio mixer to track previous volumes for a producer and to interpolate volume changes across all samples in the frame
…o early for certain transitions
|
…s at the highest expected cadence sample count
4cafa1e
to
caf59da
Compare
(cherry picked from commit 7f4a9b0)
# Conflicts: # src/core/mixer/audio/audio_mixer.cpp
…ing transition. The src will still cut to the dst at trigger_point.
This reverts commit ff18499.
…ling and audio fade logic
…nto tk-sting-debug
@Julusian any thoughts? |
@TomKaltz now that you're adding new transitions, what would you say about adding up/down directions for transitions? I think it's still just left/right, and push up/down is a common animation we do for lower thirds. We currently do it through a weird workaround of moving the layer + swap. Related to #332 |
@Sidonai-1 done 😎 |
I would love to review this and get it merged, but there are just so many changes at the same time. |
@niklaspandersson i agree there is a lot here. I will see if I can find the time to separate some of this out. |
empty
is specified as the mask file, the producer runs with no dst mask and it cuts to the dst producer at the trigger point underneath the required overlay file. Audio handling is untouched and still respects audio fade options