Skip to content

Transition improvements and additions #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

TomKaltz
Copy link
Member

@TomKaltz TomKaltz commented Apr 25, 2025

  • add fadecut, cutfade and vfade transitions.
  • add UP, DOWN (FROMBOTTOM, FROMTOP) directions to PUSH, SLIDE transitions.
  • improved auto_play_delta for all transitions so that the last frame of a producer is displayed on the last visible frame of the transition
  • modified audio mixer to track previous volumes for a producer and to interpolate volume changes across all samples in the frame (no more frame stair stepping audio fades)
  • introduced frame immediate_volume (defaults to false) so that audio volume changes are always ramped over the range of samples in a frame unless a transition or layer(still frame) needs to prevent volume ramping within a frame.
  • added "cut mode" to sting producer to more closely match the functionality of other products that support sting transitions. When empty is specified as the mask file, the producer runs with no dst mask and it cuts to the dst producer at the trigger point underneath the required overlay file. Audio handling is untouched and still respects audio fade options

-depends on CasparCG#1615
-improved auto_play_delta for all transitions so that the last frame of a producer is displayed on the last visible frame of the transition
-modified audio mixer to track previous volumes for a producer and to interpolate volume changes across all samples in the frame
@TomKaltz
Copy link
Member Author

TomKaltz commented Apr 25, 2025

One thing I still need to check is whether I intra-frame audio volume ramp/fade is correct for interlaced sources/channels.

@TomKaltz TomKaltz force-pushed the tk-cutfade branch 2 times, most recently from 4cafa1e to caf59da Compare April 28, 2025 23:50
Julusian and others added 2 commits April 29, 2025 21:39
# Conflicts:
#	src/core/mixer/audio/audio_mixer.cpp
@TomKaltz TomKaltz marked this pull request as draft May 2, 2025 04:18
@TomKaltz TomKaltz marked this pull request as ready for review May 3, 2025 02:06
@TomKaltz TomKaltz requested a review from Julusian May 3, 2025 02:06
@TomKaltz
Copy link
Member Author

@Julusian any thoughts?

@Sidonai-1
Copy link

Sidonai-1 commented May 16, 2025

@TomKaltz now that you're adding new transitions, what would you say about adding up/down directions for transitions? I think it's still just left/right, and push up/down is a common animation we do for lower thirds.

We currently do it through a weird workaround of moving the layer + swap.

Related to #332

@TomKaltz
Copy link
Member Author

what would you say about adding up/down directions for transitions?

@Sidonai-1 done 😎

@TomKaltz TomKaltz requested a review from Julusian June 22, 2025 17:43
@niklaspandersson
Copy link
Member

I would love to review this and get it merged, but there are just so many changes at the same time.
One pull request per bullet point in your description would be way easier to review. And it would come with the added benefit of a cleaner history. I don’t know if anyone care, but I think it is worth striving for at least.

@TomKaltz
Copy link
Member Author

@niklaspandersson i agree there is a lot here. I will see if I can find the time to separate some of this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants