[OpenWrt] Fix BusyBox ps unsupported flags#1621
Open
macie wants to merge 2 commits intoCISOfy:masterfrom
Open
Conversation
Command `ps ax | grep '<WORD1>|<WORD2>' | grep -v 'grep'` can be directly transformed to `IsRunning '<WORD1>' || IsRunning '<WORD2>'`. `IsRunning` supports BusyBox `ps` (without `-ax` option, see: <https://github.com/mirror/busybox/blob/master/procps/ps.c>).
BusyBox not implements flags `-ax` (see: <https://github.com/mirror/busybox/blob/master/procps/ps.c>) Calling it throws an error: `/bin/ps: unrecognized option: a`. `IsRunning` function cannot be used here due to complex searching rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors
/bin/ps: unrecognized option: aand/bin/ps: unrecognized option: xblocks multiple tests.This is a part of enabling support for OpenWrt, see: #1600.
(more details in commit messages)