-
Notifications
You must be signed in to change notification settings - Fork 6
Add auth_type to Aidbox insert #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertandremitchell hmm, is it showing up in your db correctly? that page is just pulling it from the column data, not sure why it wouldn't be showing in your browser unless it's not getting seeded properly somehow |
this was working for me! fwiw, the aidbox seeding takes a few moments (and sometimes is still spinning in the background even after the UI spins up), so @robertandremitchell it's possible that you just need the seeding to finish first before checking |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 64.99% 66.13% +1.14%
==========================================
Files 114 114
Lines 5656 5658 +2
Branches 1359 1360 +1
==========================================
+ Hits 3676 3742 +66
+ Misses 1966 1837 -129
- Partials 14 79 +65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! working for me now
…opes to Aidbox config if none are present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at this with @fzhao99 today and neither of us are quite sure why we keep seeing invalid jwt signature
errors, since the same flow is working via the UI. Possibly more weirdness with jsdom and the hacky fix for TextEncoder...
Putting this on hold til folks are back from CSTE/we can review at eng sync
15d1d32
to
f5f7290
Compare
a80af3b
to
4c71136
Compare
PULL REQUEST
Summary
Updates the Aidbox seed script to mark it as a SMART on FHIR server, so it no longer shows as auth type "none" in the table
Related Issue
Fixes #
#654
Anything else the review team should know?
Checklist