-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for Microsoft Entra ID #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 66.10% 66.08% -0.03%
==========================================
Files 104 104
Lines 4706 4720 +14
Branches 1114 1094 -20
==========================================
+ Hits 3111 3119 +8
- Misses 1583 1589 +6
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! @nickclyde , I don't have Microsoft creds; do you think they're worth getting? Happy to request, but wondering if it in favor of not holding up the ticket you could maybe do a run through of the startup for Microsoft at a parking lot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like a charm! just a flag to drop a slack message for folks to update their local setup after this goes in since we're renaming the env vars. otherwise would bork the local sign in flow
Co-authored-by: fzhao99 <[email protected]>
PULL REQUEST
Summary
This pull request introduces support for Microsoft Entra ID alongside the existing Keycloak integration.
Authentication Enhancements
src/auth.ts
and dynamic provider selection based on theNEXT_PUBLIC_AUTH_PROVIDER
environment variable. [1] [2] [3]handleClick
function insrc/app/(pages)/landingPage/landingPage.tsx
to dynamically use the selected identity provider for sign-in.Configuration Updates
.env.sample
file to include new environment variables for Microsoft Entra ID (AUTH_MICROSOFT_ENTRA_ID_ID
,AUTH_MICROSOFT_ENTRA_ID_SECRET
,AUTH_MICROSOFT_ENTRA_ID_ISSUER
) and reorganized authentication-related settings for clarity.Documentation Improvements
docs/deployment.md
to include instructions for configuring identity providers, detailing how to set theNEXT_PUBLIC_AUTH_PROVIDER
environment variable and the required settings for Keycloak and Microsoft Entra ID.Related Issue
Fixes #595 (https://linear.app/skylight-cdc/issue/QUE-280/add-support-for-microsoft-entra-id)
Additional Information
Something to keep an eye out for, I don't think this is a breaking change but good to keep in mind if we upgrade AuthJS: nextauthjs/next-auth#12616
If you want to test this locally, follow this guide with your Skylight Azure account, let me know if you need one set up