netexec: fix build + bump pyinstaller #4514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's since this bump ea655ab (because v1.3.0.r459.gb520fdf9 seemed to work) or if it's this upstream commit Pennyw0rth/NetExec@47bb146 (brings dynamic versioning and empty placeholder version) but netexec BA package is no longer working.
I haven't been able to fix the poetry setup, nor migrate to pipx, nor to a classic venv + pip.
poetry seems no longer working since dynamic-versioning, pipx fails with mysterious error that are better understandable when trying to build with venv + pip (git version command not working, vcs environment not found, all that while copying the .git/, having git as dependency or even directly pip install git+https://… in .install, then mysterious /dev/null, and many other black magic issues). I also tried to copy other method in already existing PKGBUILD. Nothing works.
For example, pipx install mentioned on the official wiki, works well on my machine, but is not in a chroot or nspawn container.
All this python virtual environment ecosystem constantly evolving and upstream project continuously keeping to complexity it is not maintainable… The irony is that the use of a virtual environment use in the first place was to avoid the dependency hell of this project (precise version pinned, old version pinned, incompatible version with AL system, git versions, etc. that were also updated very often).
But in this very dark time, I found brightness. I tried harder and after hours of unsuccessfully virtual env packaging, I RTFMed harder the official wiki to discover it's now possible to build the whole python project as a static binary. So I did so and it works!
Humanitypentest community is saved!