Skip to content

above: add package. #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

above: add package. #4481

wants to merge 1 commit into from

Conversation

s7x
Copy link
Contributor

@s7x s7x commented Mar 6, 2025

Added the Above tool by casterbye.

@s7x s7x requested a review from noptrix as a code owner March 6, 2025 17:05
@s7x
Copy link
Contributor Author

s7x commented Mar 6, 2025

Ping @noraj, this is why I did not want to change this package too much. With the new templates we have (using the pip version for example), this is the result:

image

image

image

'blackarch-voip')
url='https://github.com/casterbyte/Above'
license=('Apache-2.0')
depends=('python' 'python-colorama' 'scapy')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it needs scapy (cli) and not python-scapy (library)?

@noraj
Copy link
Contributor

noraj commented Mar 6, 2025

Ping @noraj, this is why I did not want to change this package too much. With the new templates we have (using the pip version for example), this is the result:

image

image

image

It's not your fault or the template fault, it's badly packaged upstream.

/usr/bin/above is the proper wrapper created by pip that works way better than the dirty 2 lines bash wrapper that cd /usr/share/package. But here above is poorly developed, instead of using a standard file architecture, havign separate library files than a CLI consuming the lirary, a proper pyproject.toml and a properly declared entrypoint, it's a dirty 1100 LoC one-file script, packaged with the old setup.py and wrongly declared entrypoint. /usr/bin/above.py shouldn't be there but somewhere in /usr/lib/python3.13/site-packages/above/. above_oui_dict.py is also wrongly deployed under /usr/lib/python3.13/site-packages/above_oui_dict.py instead of /usr/lib/python3.13/site-packages/above/above_oui_dict.py due to the bad setup.py.

@noraj
Copy link
Contributor

noraj commented Mar 6, 2025

/usr/bin/above.py shouldn't be there but somewhere in /usr/lib/python3.13/site-packages/above/. above_oui_dict.py is also wrongly deployed under /usr/lib/python3.13/site-packages/above_oui_dict.py instead of /usr/lib/python3.13/site-packages/above/above_oui_dict.py due to the bad setup.py.

This because it blindly uses packages=find_packages() without argument AND the python files are on the root of the directory instead of in a above folder. etc. I'll submit a package with prepare() that fix upstream mess.

@noraj
Copy link
Contributor

noraj commented Mar 6, 2025

Also you use python/PKGBUILD-python-PEP517-pip that is made for pyproject.toml instead of python/PKGBUILD-python-PEP517-setuptools that is made for setup.py.

@noraj noraj closed this Mar 6, 2025
@noraj noraj mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants