Throw InvalidOperationException with actionable message when custom credential not registered #3626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw InvalidOperationException with actionable message when custom credential not registered
Throw InvalidOperationException when custom credential not wired up
Description
Previously, forgetting to register a custom signed assertion provider (e.g., not calling
services.AddOidcFic()) would log an error but continue execution, eventually causing MSAL to be called withWithClientAssertion(null)and throwing an obscure "Delegate is null" exception.Now throws
InvalidOperationExceptionimmediately with actionable guidance:Before:
After:
Changes
DefaultCredentialsLoader.CustomSignedAssertion.cs: ThrowInvalidOperationExceptionafter logging when providers not registered, provider name missing, or provider not foundCertificateErrorMessage.cs: Enhanced error messages (IDW10112, IDW10113, IDW10114) with specific registration examplesCustomSignedAssertionProviderTests.cs: Updated 7 existing tests to validate exception throwing behaviorInternalAPI.Unshipped.txt: Documented changed internal API constantsFixes #3652
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.