(v5) bugfix get native account

lib/msal-browser/src/cache/AccountManager.ts

@@ -35,12 +35,7 @@ export function getAccount(
     browserStorage: BrowserCacheManager,
     correlationId: string
 ): AccountInfo | null {
-    logger.trace("getAccount called", correlationId);
-    if (Object.keys(accountFilter).length === 0) {
-        logger.warning("getAccount: No accountFilter provided", correlationId);
-        return null;
-    }
-
+    logger.trace("getAccount called");
     const account: AccountInfo | null = browserStorage.getAccountInfoFilteredBy(
         accountFilter,
         correlationId

lib/msal-browser/test/cache/BrowserCacheManager.spec.ts

@@ -35,6 +35,7 @@ import {
     AccountEntityUtils,
     Constants,
     CredentialEntity,
+    AccountFilter,
 } from "@azure/msal-common";
 import {
     BrowserCacheLocation,
@@ -50,6 +51,7 @@ import { BrowserPerformanceClient } from "../../src/telemetry/BrowserPerformance
 import { EventHandler } from "../../src/event/EventHandler.js";
 import { version } from "../../src/packageMetadata.js";
 import * as CacheKeys from "../../src/cache/CacheKeys.js";
+import { getAccount } from "../../src/cache/AccountManager.js";
 
 describe("BrowserCacheManager tests", () => {
     let cacheConfig: Required<CacheOptions>;
@@ -2311,6 +2313,23 @@ describe("BrowserCacheManager tests", () => {
                         )
                     ).toEqual(testAccount);
                 });
+
+
+                it("getAccount returns null if accountfilter is passed but values are undefined", () => {
+                    const testAccountFilter: AccountFilter = {
+                        loginHint: undefined,
+                        sid: undefined,
+                    };
+
+                    expect(
+                        getAccount(
+                            testAccountFilter,
+                            logger,
+                            browserSessionStorage,
+                            TEST_CONFIG.CORRELATION_ID
+                        )
+                    ).toEqual(null);
+                });
             });
 
             describe("IdTokenCredential", () => {

lib/msal-common/src/cache/CacheManager.ts

@@ -295,6 +295,15 @@ export abstract class CacheManager implements ICacheManager {
         accountFilter: AccountFilter,
         correlationId: string
     ): AccountInfo | null {
+          if (
+            Object.keys(accountFilter).length === 0 ||
+            Object.values(accountFilter).every((value) => !value)
+        ) {
+            this.commonLogger.warning(
+                "getAccountInfoFilteredBy: Account filter is empty or invalid, returning null"
+            );
+            return null;
+        }
         const allAccounts = this.getAllAccounts(accountFilter, correlationId);
         if (allAccounts.length > 1) {
             // If one or more accounts are found, prioritize accounts that have an ID token

lib/msal-common/test/cache/CacheManager.spec.ts

@@ -686,6 +686,18 @@ describe("CacheManager.ts test cases", () => {
             ).toBeNull();
         });
 
+         it("returns null if filter passed in is empty", () => {
+            expect(
+                mockCache.cacheManager.getAccountInfoFilteredBy(
+                    {
+                        homeAccountId: "",
+                        loginHint: "",
+                    },
+                    RANDOM_TEST_GUID
+                )
+            ).toBeNull();
+        });
+
         it("returns an account matching filter", () => {
             const resultAccount =
                 mockCache.cacheManager.getAccountInfoFilteredBy(