Open
Conversation
bgavrilMS
reviewed
Apr 3, 2025
bgavrilMS
reviewed
Apr 3, 2025
chlowell
previously approved these changes
Apr 3, 2025
bgavrilMS
reviewed
Apr 3, 2025
bgavrilMS
reviewed
Apr 3, 2025
bgavrilMS
reviewed
Apr 3, 2025
bgavrilMS
reviewed
Apr 3, 2025
1 task
chlowell
reviewed
Apr 11, 2025
chlowell
reviewed
Apr 11, 2025
chlowell
reviewed
Apr 17, 2025
chlowell
approved these changes
Apr 18, 2025
Contributor
chlowell
left a comment
There was a problem hiding this comment.
I approve of the Go content. Someone from the MSAL side should review the doc content
gladjohn
reviewed
Apr 29, 2025
|
|
||
| // App Service | ||
| appServiceAPIVersion = "2019-08-01" | ||
| appServiceAPIVersion = "2025-03-30" |
There was a problem hiding this comment.
this looks good and matches the app service new version. We just want to make sure not to merge this PR yet, as App Service rollout is still happening.
Collaborator
Author
There was a problem hiding this comment.
How does it work in MSAL .net about guarding the release or the version blocking ?
|
@4gust this looks good, did not approve it because of the app service api-version update. anyway we can guard it? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Title: Add Token Revocation Handling and Enhanced Testing for App Service in Managed Identity
Description:
This PR introduces a new feature to handle token revocation scenarios in App Service managed identity and enhances testing to ensure robust behavior. The changes focus on handling claims challenges, bad access tokens from the cache, and validating client capabilities.
Changes:
Feature Implementation:
Token Revocation Handling:
claimsparameter included in the URL to obtain a fresh token.Bad Access Token Handling:
New Unit Tests:
TestAppServiceWithClaimsAndBadAccessToken
TestAppServiceWithClientCapabilities
client_capabilitiesparameter is correctly passed and processed.