Downgrade System.Formats.Asn1 to match ID web #5583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Nov 17, 2025
Contributor
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @Avery-Dunn
gladjohn
approved these changes
Nov 17, 2025
neha-bhargava
approved these changes
Nov 17, 2025
This was referenced Nov 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit the System.Formats.Asn1 dependency was added to MSAL .NET: b54af18
We used version 9.0.0, which conflicts with the version 8.0.1 used in ID Web: https://github.com/AzureAD/microsoft-identity-web/blob/d993ba7980af41f866e96b9d3e15f9d6a4a49d57/Directory.Build.props#L98
Since MSAL.NET appears to compile fine with 8.0.1, this PR just downgrades the dependency here in MSAL.NET to avoid having to upgrade it in ID Web: https://github.com/AzureAD/microsoft-identity-web/pull/3583/files#r2535265213