[minor][feature]: Add more execution flow tag point#1694
Open
kaisong1990 wants to merge 12 commits intodevfrom
Open
[minor][feature]: Add more execution flow tag point#1694kaisong1990 wants to merge 12 commits intodevfrom
kaisong1990 wants to merge 12 commits intodevfrom
Conversation
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -25,6 +25,8 @@ | |||
| #import "MSIDInteractiveTokenRequestParameters.h" | |||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional execution-flow tagging in IdentityCore to improve traceability of controller selection and SSO remote token request lifecycles.
Changes:
- Introduces new execution-flow tag enums and tag-to-string mappers for controller factory, SSO remote interactive, and SSO remote silent flows.
- Inserts new execution-flow tags at key decision points in
MSIDRequestControllerFactory(broker usage, SSO extension/XPC availability, fallback paths, finish). - Inserts new execution-flow tags in SSO remote token requests around authority resolution, operation response handling, and completion.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| IdentityCore/src/telemetry/execution_flow/MSIDExecutionFlowConstants.h | Adds new tag enums and tag-to-string function declarations for controller factory + SSO remote requests. |
| IdentityCore/src/telemetry/execution_flow/MSIDExecutionFlowConstants.m | Implements tag-to-string mappings for the newly added enums. |
| IdentityCore/src/requests/broker/MSIDSSORemoteSilentTokenRequest.m | Adds execution-flow tags for authority resolution, operation response handling, and completion. |
| IdentityCore/src/requests/broker/MSIDSSORemoteInteractiveTokenRequest.m | Adds execution-flow tags for authority resolution, operation response handling, and completion. |
| IdentityCore/src/controllers/MSIDRequestControllerFactory.m | Adds execution-flow tags around silent/interactive controller selection logic and fallback decisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IdentityCore/src/requests/broker/MSIDSSORemoteSilentTokenRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/src/requests/broker/MSIDSSORemoteInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
…st.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Request.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…TS (#1692) ## PR Title Format **Required Format:** `[Keyword1] [Keyword2]: Description` - **Keyword1:** `major`, `minor`, or `patch` (case-insensitive) - **Keyword2:** `feature`, `bugfix`, `engg`, or `tests` (case-insensitive) **Examples:** - `[MAJOR] [Feature]: new API` - `[minor] [bugfix]: fix crash` - `[PATCH][tests]:add coverage` ## Proposed changes Add additional error handling when we receive the following error combination from ESTS: - error = MSIDServerInvalidRequest - error_code = 50142 (SecureChangePasswordDueToConditionalAccess) We are adding this change such that OneAuth has ability to map this specific error to interaction required. Related ADO item: ## Type of change - [ ] Feature work - [ ] Bug fix - [ ] Documentation - [X] Engineering change - [ ] Test - [ ] Logging/Telemetry ## Risk - [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes) - [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features) - [X] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes) ## Additional information --------- Co-authored-by: Maximus Agubuzo <maximusagubuzo@MacBook-Air-6.local> Co-authored-by: agubuzomaximus <agubuzomaximus@gmail.com> Co-authored-by: Fidelia Nawar <fidelianawar@Fidelias-MacBook-Pro.local>
kaisong1990
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH][tests]:add coverageProposed changes
This pull request introduces comprehensive execution flow logging across multiple controller and request classes in the
IdentityCoremodule. The changes add logging tags at key decision points and completion blocks, with contextual information such as error codes and correlation IDs. This enhancement will improve traceability and debugging for silent and interactive token requests, as well as SSO extension requests.Execution flow logging enhancements
MSIDExecutionFlowLoggerandMSIDExecutionFlowConstantsimports toMSIDRequestControllerFactory.m,MSIDSSORemoteInteractiveTokenRequest.m, andMSIDSSORemoteSilentTokenRequest.mto enable logging functionality. [1] [2] [3]SSO extension request logging
MSIDSSORemoteInteractiveTokenRequest.mfor authority resolution, operation response handling, and completion blocks, including error codes and correlation IDs. [1] [2] [3]MSIDSSORemoteSilentTokenRequest.mfor operation response handling and completion blocks, including error codes and correlation IDs. [1] [2]Type of change
Risk
Additional information
AB#3407672