Add mapping for MSIDServerInvalidRequest suberror#1659
Open
fidelianawar wants to merge 2 commits intodevfrom
Open
Add mapping for MSIDServerInvalidRequest suberror#1659fidelianawar wants to merge 2 commits intodevfrom
fidelianawar wants to merge 2 commits intodevfrom
Conversation
fidelianawar
requested review from
Copilot,
genderbread and
josephpab
and removed request for
Copilot
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -367,6 +367,9 @@ typedef NS_ENUM(NSInteger, MSIDErrorCode) | |||
|
|
|||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
fidelianawar
changed the title
| { | ||
| return MSIDErrorCodeForOAuthError(oauthError, defaultCode); | ||
| } | ||
| if (oauthError && [oauthError caseInsensitiveCompare:@"invalid_request"] == NSOrderedSame && [subError caseInsensitiveCompare:@"50142"] == NSOrderedSame) |
Contributor
There was a problem hiding this comment.
Need to confirm that we get a error value in number format. Also, does it have to have a minus sign part of it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
ESTS returns sub error 50142 for invalid_request, which needs to be mapped for OneAuth layer error handling
Type of change
Risk
Additional information