Open
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the key vault configuration to use the new Mobile Build Vault and adjusts related UI automation interactions accordingly.
- Updated the regex pattern in AadLoginComponentHandler for a more flexible password button matching.
- Renamed variables and methods in the key vault configuration to reflect the new Mobile Build Vault naming.
- Updated the base URL in the ApiClient to point to the Mobile Build Vault.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uiautomationutilities/src/main/java/com/microsoft/identity/client/ui/automation/interaction/microsoftsts/AadLoginComponentHandler.java | Regex pattern updated to support flexible matching for the "Use your password" button. |
| keyvault/src/main/java/com/microsoft/identity/internal/test/keyvault/Configuration.java | Renamed variable and method to clearly indicate use of the Mobile Build Vault. |
| keyvault/src/main/java/com/microsoft/identity/internal/test/keyvault/ApiClient.java | Updated the vault base URL to the Mobile Build Vault endpoint. |
Comments suppressed due to low confidence (1)
keyvault/src/main/java/com/microsoft/identity/internal/test/keyvault/Configuration.java:19
- [nitpick] The variable and method renaming to reference Mobile Build Vault improves clarity; verify consistency across all related references.
private static ApiClient buildAutomationApiClient = new ApiClient(ApiClient.BUILD_AUTOMATION_VAULT_BASE_PATH);
| otherWays.click(); | ||
|
|
||
| UiAutomatorUtils.handleButtonClickForObjectWithExactText("Use your password"); | ||
| UiAutomatorUtils.handleButtonClickForObjectWithRegexMatch("^Use \\w* password$"); |
There was a problem hiding this comment.
The regex pattern provides flexibility; however, ensure it precisely matches the intended button text to avoid unintended matches.
Suggested change
| UiAutomatorUtils.handleButtonClickForObjectWithRegexMatch("^Use \\w* password$"); | |
| UiAutomatorUtils.obtainUiObjectWithExactText("Use my password", CommonUtils.FIND_UI_ELEMENT_TIMEOUT_SHORT).click(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the new key vault Mobile Build Vault