Open
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build automation vault endpoint to point at the newly created mobile build vault.
- Changed the
BUILD_AUTOMATION_VAULT_BASE_PATHconstant to the new URL.
Comments suppressed due to low confidence (1)
keyvault/src/main/java/com/microsoft/identity/internal/test/keyvault/ApiClient.java:76
- [nitpick] The constant name
BUILD_AUTOMATION_VAULT_BASE_PATHno longer reflects the new 'mobilebuildvault' URL. Consider renaming it to something likeMOBILE_BUILD_VAULT_BASE_PATHorMOBILE_BUILD_AUTOMATION_VAULT_BASE_PATHfor clarity.
public static final String BUILD_AUTOMATION_VAULT_BASE_PATH = "https://mobilebuildvault.vault.azure.net";
mohitc1
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update keyvault URL. Use newly created vault