Reduce memory consumption by avoiding adding items when queue is full #3375
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory consumption by avoiding adding items when queue is full
EventBasedLRUCache cleanup: remove TaskCount and simplify code
Description
Under heavy load, stress tests showed the LRUCache was unable to keep up. Items are now rejected when the cache is full or compacting to prevent kernel object accumulation when SignatureProviders aren't actually cached.
Source Changes
EventBasedLRUCache.cs
_taskCountfield andTaskCountproperty (task now starts once in constructor)Interlocked.CompareExchangeto direct readInMemoryCryptoProviderCache.cs
TaskCountpropertyInternalAPI.Shipped.txt / InternalAPI.Unshipped.txt
TaskCountAPI entries from both classesTest Changes
CryptoProviderFactoryTests.cs
TaskCount:ProviderCache_EnsureNoException_MultipleThreads,ProviderCache_EnsureNoLeakingTasks_SecurityTokenHandler_*Fixes #3239
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.