Skip to content

Boost: remove ISA #44459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025
Merged

Boost: remove ISA #44459

merged 3 commits into from
Jul 25, 2025

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jul 24, 2025

Fixes HOG-210

Proposed changes:

  • Removes ISA from the code base.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Linear

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Ensures everything builds.
  • Click through to ensure no random references or links remain.

@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Pri] Normal labels Jul 24, 2025
@kraftbj kraftbj self-assigned this Jul 24, 2025
@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests Docs labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Jul 24, 2025

Code Coverage Summary

Coverage changed in 6 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/class-jetpack-boost.php 71/124 (57.26%) -2.91% 6 💔
projects/plugins/boost/app/lib/class-premium-features.php 21/25 (84.00%) -0.62% 0 💚
projects/plugins/boost/app/assets/src/js/features/image-guide/image-guide.tsx 0/5 (0.00%) 0.00% -2 💚
projects/plugins/boost/app/assets/src/js/pages/index/index.tsx 0/13 (0.00%) 0.00% -3 💚
projects/plugins/boost/app/assets/src/js/pages/purchase-success/purchase-success.tsx 0/9 (0.00%) 0.00% -6 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@kraftbj kraftbj added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jul 24, 2025
Copy link
Contributor

@LiamSarsfield LiamSarsfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I gave it a whirl on JN and no issues were found.

@kraftbj kraftbj merged commit 1667418 into trunk Jul 25, 2025
69 checks passed
@kraftbj kraftbj deleted the remove/boost/isa/remove-the-code-HOG-210 branch July 25, 2025 20:16
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Image Size Analysis Docs I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Pri] Normal [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants