Skip to content

Boost: Add E2E Tests for Cornerstone Pages #44458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025

Conversation

LiamSarsfield
Copy link
Contributor

@LiamSarsfield LiamSarsfield commented Jul 24, 2025

Fixes HOG-225: E2E Tests for Cornerstone Pages

Proposed changes:

Add End-to-End (E2E) test coverage for the Jetpack Boost Cornerstone Pages.

Test Coverage:

  • Panel visibility and toggle functionality
  • Adding and validating custom Cornerstone Pages
  • Free plan limits (1 custom page) vs Premium plan limits (10 custom pages)
  • URL validation: relative URLs, different site rejection, homepage rejection
  • Prerender toggle functionality (speculation rules)
  • Upgrade CTA display for free users
  • Correct page count summaries in panel titles

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Prerequisites:

  • Ensure E2E Tests all pass within the build, especially: E2E Tests / Jetpack Boost - Cornerstone Pages e2e tests

- Introduced a new plugin to mock premium features for end-to-end testing.
- Implemented functions to manage mocked features and set up necessary filters.
- Added comprehensive E2E tests for Cornerstone Pages, covering visibility, validation, and functionality for both free and premium plans.
- Ensured proper handling of custom pages and error messages based on plan limitations.
- Added a new project configuration for Cornerstone Pages in E2E tests.
- Updated the CLI to include 'speculation_rules' in the modules for E2E tests.
- Enhanced the Prerender component with a data-testid for better test targeting.
- Introduced new methods in JetpackBoostPage for managing Cornerstone Pages.
- Updated E2E tests to validate Cornerstone Pages functionality, including visibility and URL handling.
- Implemented mock handling for premium features in the prerequisites builder.
@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Tests] Includes Tests Actions GitHub actions used to automate some of the work around releases and repository management Docker E2E Tests labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 24, 2025
Copy link

jp-launch-control bot commented Jul 24, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@LiamSarsfield LiamSarsfield added [Type] Janitorial and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 24, 2025
@LiamSarsfield LiamSarsfield changed the title Add/boost/e2e-tests-cornerstone-pages-HOG-225 Boost: Add E2E Tests for Cornerstone Pages Jul 24, 2025
@LiamSarsfield LiamSarsfield marked this pull request as ready for review July 24, 2025 18:46
@LiamSarsfield LiamSarsfield requested review from dilirity, kraftbj and a team July 24, 2025 18:46
@LiamSarsfield LiamSarsfield added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 24, 2025
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it. Going to merge it and let the good times roll.

@kraftbj kraftbj merged commit 529d1f6 into trunk Jul 24, 2025
120 of 122 checks passed
@kraftbj kraftbj deleted the add/boost/e2e-tests-cornerstone-pages-HOG-225 branch July 24, 2025 20:30
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants