-
Notifications
You must be signed in to change notification settings - Fork 823
Boost: Add E2E Tests for Cornerstone Pages #44458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Introduced a new plugin to mock premium features for end-to-end testing. - Implemented functions to manage mocked features and set up necessary filters. - Added comprehensive E2E tests for Cornerstone Pages, covering visibility, validation, and functionality for both free and premium plans. - Ensured proper handling of custom pages and error messages based on plan limitations.
- Added a new project configuration for Cornerstone Pages in E2E tests. - Updated the CLI to include 'speculation_rules' in the modules for E2E tests. - Enhanced the Prerender component with a data-testid for better test targeting. - Introduced new methods in JetpackBoostPage for managing Cornerstone Pages. - Updated E2E tests to validate Cornerstone Pages functionality, including visibility and URL handling. - Implemented mock handling for premium features in the prerequisites builder.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it. Going to merge it and let the good times roll.
Fixes HOG-225: E2E Tests for Cornerstone Pages
Proposed changes:
Add End-to-End (E2E) test coverage for the Jetpack Boost Cornerstone Pages.
Test Coverage:
Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Prerequisites:
E2E Tests / Jetpack Boost - Cornerstone Pages e2e tests