Skip to content

Autoloader: remove unneeded dev files from production package #44456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 24, 2025

Proposed changes:

This PR ensures that some of the development files currently shipping with the stable version of automattic/jetpack-autoloader are not included in the final release.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Not much to test here ; just make sure the files I've added to the config are indeed not needed in the stable version of the package.

@jeherve jeherve requested a review from a team July 24, 2025 16:34
@jeherve jeherve self-assigned this Jul 24, 2025
@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Type] Janitorial [Pri] Low Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/autoloader-exclude-stable branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/autoloader-exclude-stable

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, though perhaps eventually some of these should be moved to the root .gitattributes.

@kraftbj kraftbj merged commit 136090b into trunk Jul 24, 2025
79 of 81 checks passed
@kraftbj kraftbj deleted the update/autoloader-exclude-stable branch July 24, 2025 20:31
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Autoloader [Pri] Low Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants