Skip to content

Boost: Fix speed scores refreshing on cornerstone pages update #44445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025

Conversation

dilirity
Copy link
Member

Fixes HOG-223

Proposed changes:

  • Check if Critical CSS module is active before marking Critical CSS as "needs update", forcing it to refresh speed scores.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Setup this branch and enable Boost;
  • Keep Critical CSS and LCP disabled;
  • Wait for Speed Scores to load;
  • Update the Cornerstone Pages list - Speed Scores shouldn't refresh;
  • Enable Critical CSS and wait for Speed Scores to load;
  • Update the Cornerstone Pages list and wait for Critical CSS to complete regenerating. Speed Scores should refresh after that.

@dilirity dilirity self-assigned this Jul 24, 2025
@dilirity dilirity added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Speed Score issues related to Jetpack Boost's Speed Score Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Jul 24, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Jul 24, 2025

Code Coverage Summary

No summary data is available for parent commit 1667418, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 1667418 is available.

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Let's merge.

@kraftbj kraftbj merged commit 53d3dc4 into trunk Jul 25, 2025
70 checks passed
@kraftbj kraftbj deleted the fix/boost/cornerstone-pages/dont-update-speed-scores branch July 25, 2025 20:30
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Speed Score issues related to Jetpack Boost's Speed Score I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants