-
Notifications
You must be signed in to change notification settings - Fork 823
Jetpack Modules: Avoid using regexes when possible #44324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Modules: Avoid using regexes when possible #44324
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. One suggestion on ordering to have the still-needed preg_matches occur after the simple comparisons have been exhausted.
@@ -276,15 +269,15 @@ public function callback_action_catch_sitemap_urls() { | |||
} | |||
|
|||
// Catch sitemap xsl. | |||
if ( preg_match( $regex['sitemap-style'], $request['sitemap_name'] ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine it would be more performant to have all of the simple comparisons before any of the preg_match
es. Any reason not to have all of them occur before the first preg_match
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't think of that, thanks for the suggestion!
Updated in 60df508.
While looking into OOM errors in the modules, I noticed that some checks can benefit from using simple string comparison or str_contains checks.
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: