Skip to content

Boost: Exclude builder plugins' post types from Critical CSS #44280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Jul 11, 2025

Fixes HOG-184

This is a collection of post types that we've received complaints for. Some are registered correctly, but I added them anyway, to avoid having to patch Boost if down the line a plugin messes up their post type registration.

Divi Builder isn't in the list, as the custom post types it registers aren't available when Source Providers are collected.

I didn't outline testing instructions as most plugins are premium and the steps to make posts from their post types show in the source providers list are quite lengthy.

Proposed changes:

  • Exclude post types of popular builder plugins from Critical CSS generation:
    • Beaver Builder;
    • Breakdance;
    • Elementor (already present, just added another post type).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-184

Does this pull request change what data or activity we track or use?

no

Testing instructions:

N/A

@dilirity dilirity self-assigned this Jul 11, 2025
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Jul 11, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Focus] Compatibility Ensuring our products play well with third-parties label Jul 11, 2025
Copy link

jp-launch-control bot commented Jul 11, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/jetpack-boost.php 0/114 (0.00%) 0.00% 4 💔
projects/plugins/boost/compatibility/elementor.php 0/11 (0.00%) 0.00% 2 ❤️‍🩹

2 files are newly checked for coverage.

File Coverage
projects/plugins/boost/compatibility/beaver-builder.php 0/5 (0.00%) 💔
projects/plugins/boost/compatibility/breakdance.php 0/6 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 11, 2025
@dilirity dilirity merged commit 2aaa389 into trunk Jul 14, 2025
82 of 83 checks passed
@dilirity dilirity deleted the update/boost/compatibility/ignore-builder-post-types-HOG-184 branch July 14, 2025 08:21
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Focus] Compatibility Ensuring our products play well with third-parties I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants