-
Notifications
You must be signed in to change notification settings - Fork 823
Boost: Exclude builder plugins' post types from Critical CSS #44280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Exclude builder plugins' post types from Critical CSS #44280
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
2 files are newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
Fixes HOG-184
This is a collection of post types that we've received complaints for. Some are registered correctly, but I added them anyway, to avoid having to patch Boost if down the line a plugin messes up their post type registration.
Divi Builder isn't in the list, as the custom post types it registers aren't available when Source Providers are collected.
I didn't outline testing instructions as most plugins are premium and the steps to make posts from their post types show in the source providers list are quite lengthy.
Proposed changes:
Other information:
Jetpack product discussion
HOG-184
Does this pull request change what data or activity we track or use?
no
Testing instructions:
N/A