Skip to content

Boost: Allow control over whether a module should run or not #44246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Jul 9, 2025

Fixes HOG-206

Proposed changes:

  • Add WP filter (jetpack_boost_can_module_run) to allow developers more control over which module should run its functionality (useful for local development).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-206

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Test that everything still works

  • Setup this on a jurassic ninja and make sure it works as expected. Test both free and premium and make sure that all features work;

Test the filter

  • Setup this locally and make sure it's connected to your local Boost Cloud instance;
  • Add this snippet to force modules to run their functionality:
add_filter( 'jetpack_boost_can_module_run', '__return_true' );

@dilirity dilirity requested review from kraftbj and LiamSarsfield July 9, 2025 13:52
@dilirity dilirity self-assigned this Jul 9, 2025
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/modules/class-modules-setup.php 0/111 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 10, 2025
@dilirity dilirity merged commit 7e48ed4 into trunk Jul 11, 2025
81 checks passed
@dilirity dilirity deleted the update/boost/allow-modules-to-run-local-dev-HOG-206 branch July 11, 2025 08:10
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants