Skip to content

Boost: Update UI to account for a website that's not publicly available #44171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 4, 2025

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Jul 2, 2025

Fixes HOG-14

This mostly affects WoA sites marked as "private".

The UI will now mention that the website is not "publicly accessible" instead of being "offline" when it's set to "private".

CleanShot 2025-07-02 at 15 30 47@2x

Here's what an unavailable feature looks like, when the website is not accessible:

CleanShot 2025-07-02 at 15 31 15@2x

Unfortunately, since the endpoint to retrieve Boost's features returns a 403 for WoA sites, we can't know if the website is using the free or premium.

If a website was using "premium", it would revert to "free". The UI would show:

  • Cornerstone Pages would list all entries that a user has added, but they can't be edited (as limit for "free" is 1 entry);
  • Critical CSS instead of Cloud CSS;
  • Image CDN would be disabled, since Jetpack forces it to "off" when the website is "private" and both are synced;
  • Image Size Analyzer disappears;

Proposed changes:

  • Update the Boost UI to mention that the website is "not publicly accessible" instead of "offline";
  • Introduce PHP interface to help differentiate between features that work offline and features that need the website to be publicly accessible;
  • Update UI for Cloud CSS, LCP, Image CDN and Image Size Analyzer, to show that they require the website to be online to function properly;
  • Update above mentioned features to not initialize their functionality if the website is not publicly available.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-14

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Make sure the website is set to "Public" before starting your tests. To change that, go to Settings -> Reading and change the Site visibility option to Public;
  • Use the Jetpack Beta tester to deploy this on a WoA site (Jurassic Ninja should work);
  • Setup Boost and make sure everything works as expected (speed scores load, LCP and Image CDN work, etc);
  • Now change the Site visibility to Private and go back to the Boost settings page;
  • The UI should show the same message as the one from the screenshot at the top (for LCP as well).

@dilirity dilirity self-assigned this Jul 2, 2025
@dilirity dilirity changed the title Boost: Update UI to properly note offline mode for modules Boost: Update UI to properly note offline mode Jul 2, 2025
@github-actions github-actions bot added [Boost Feature] Cloud CSS [Boost Feature] Image Size Analysis [Boost Feature] Image CDN aka Photon [Boost Feature] Lcp [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 2, 2025
@dilirity dilirity changed the title Boost: Update UI to properly note offline mode Boost: Update UI to account for a website that's not publicly available Jul 2, 2025
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 2, 2025
Copy link

jp-launch-control bot commented Jul 2, 2025

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/modules/class-modules-setup.php 0/110 (0.00%) 0.00% 8 💔
projects/plugins/boost/app/assets/src/js/features/module/module.tsx 0/31 (0.00%) 0.00% 3 ❤️‍🩹
projects/plugins/boost/app/admin/class-config.php 43/44 (97.73%) 0.05% 0 💚

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/contracts/interface-needs-website-to-be-public.php 0/0 (—%) 🤷

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@dilirity dilirity added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jul 2, 2025
@dilirity dilirity marked this pull request as ready for review July 2, 2025 12:36
@dilirity dilirity added the [Status] Needs Review This PR is ready for review. label Jul 2, 2025
@dilirity dilirity merged commit 8e7506c into trunk Jul 4, 2025
65 checks passed
@dilirity dilirity deleted the update/boost/offline-mode-HOG-14 branch July 4, 2025 09:37
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Boost Feature] Cloud CSS [Boost Feature] Image CDN aka Photon [Boost Feature] Image Size Analysis [Boost Feature] Lcp I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants