-
Notifications
You must be signed in to change notification settings - Fork 823
Boost: Update UI to account for a website that's not publicly available #44171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 3 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
Fixes HOG-14
This mostly affects WoA sites marked as "private".
The UI will now mention that the website is not "publicly accessible" instead of being "offline" when it's set to "private".
Here's what an unavailable feature looks like, when the website is not accessible:
Unfortunately, since the endpoint to retrieve Boost's features returns a 403 for WoA sites, we can't know if the website is using the free or premium.
If a website was using "premium", it would revert to "free". The UI would show:
Proposed changes:
Other information:
Jetpack product discussion
HOG-14
Does this pull request change what data or activity we track or use?
no
Testing instructions:
Settings -> Reading
and change theSite visibility
option toPublic
;Site visibility
toPrivate
and go back to the Boost settings page;