Use pkg-config to locate libprofiler #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmv
force-pushed
the
pkg-config
branch
2 times, most recently
from
38f6840 to
d123011
Compare
There is no guarantee that libprofiler is available on "standard" locations, which means that simply trying to link to it with -lprofiler is bound to fail. For example: a user may have installed gperftools under their home directory, in which case this crate cannot find it. To resolve this, use pkg-config to locate the library. This allows this crate to learn all compiler and linker flags (in particular, -L) needed to use the libprofiler library.
|
Ping! Any chance this could be merged and a new release made with it? |
|
Sorry for the huge delay. I lack time to manage my various public repos at the moment :(. If the PR still looks good to you after the conflict resolution I will merge and republish the crate. |
|
Seems good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that libprofiler is available on "standard"
locations, which means that simply trying to link to it with -lprofiler
is bound to fail.
For example: a user may have installed gperftools under their home
directory, in which case this crate cannot find it.
To resolve this, use pkg-config to locate the library. This allows
this crate to learn all compiler and linker flags (in particular, -L)
needed to use the libprofiler library.