Skip to content

refactor(dice): migrate wizard and kickoff die visuals to DieD6/DieD16 - #424

Merged
Alountk merged 1 commit into
mainfrom
feat/die-migration
Nov 18, 2026
Merged

Alountk merged 1 commit into
mainfrom
feat/die-migration

Conversation

@Alountk

@Alountk Alountk commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Qué

T34 (L121) — los visuales de dado de la app migrados a los componentes compartidos:

Sitio Antes Ahora
Wizard · El Clima y el sorteo (1D6) dado plano DieD6 (size 40) con «Tirar 1D6» byte-idéntico
Wizard · resultado aceptado de Plegarias (1D16) glifo plano DieD16 (solo display)
Puerta del kickoff · duelo TÚ/RIVAL (×2) die card editorial DieD6 con «Tirar 1D6 · TÚ / RIVAL»
  • Los componentes ganan una prop rollLabel (aditiva) para que todos los strings pineados salgan igualito (L56: cero strings tocados, verificado)
  • Fuera de cobertura con motivo (todo reportado, nada tocado): el 1D3 de Los Hinchas (otro dado — glifo byte-idéntico), los campos de entrada manual (el input posee el valor; un DieD6 en null mentiría la cara), chips/steppers (cierre, RollStepper — no son caras de dado), chips de bloqueo del dock (never-touch — follow-up)
  • Delta documentado: tras registrar, los sitios migrados muestran el estado sin botón en vez de un botón deshabilitado (más fuerte que el pin; triangulado)

Verificación

  • RED observado (6 failed) → 10 suites 218 passed + 6 skipped · tsc 0 · lint 0 errores

Risk: none

T34 (L121): every in-scope die-face visual now renders the shared components — wizard Clima + sorteo (1D6 -> DieD6, size 40, rollLabel keeping «Tirar 1D6» byte-identical), wizard prayer accepted result (1D16 -> display-only DieD16), kickoff GateDie duel x2 (DieD6 with «Tirar 1D6 · TÚ/RIVAL» labels). Components gain an optional rollLabel prop (purely additive, pinned per component). Out-of-coverage kept with reasons: Los Hinchas 1D3 (different die — flat glyph byte-identical, boundary-pinned), manual-entry fields (input owns the value; a null DieD6 would lie about an empty face), chips/steppers (closure, rollStepper — not die faces), dock block-face chips (never-touch surface — follow-up). Zero pinned strings touched (L56 verified). Documented behavior delta: migrated sites render the buttonless locked state after recording (stronger than the visible-but-disabled pin; pinned as TRIANGULATE).
@Alountk Alountk added the type:chore Maintenance/tooling label Nov 18, 2026
@Alountk
Alountk merged commit 4bbd02d into main Nov 18, 2026
11 of 12 checks passed
@Alountk
Alountk deleted the feat/die-migration branch November 18, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:chore Maintenance/tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant