Repository navigation
refactor(dice): migrate wizard and kickoff die visuals to DieD6/DieD16 - #424
Merged
Merged
Conversation
T34 (L121): every in-scope die-face visual now renders the shared components — wizard Clima + sorteo (1D6 -> DieD6, size 40, rollLabel keeping «Tirar 1D6» byte-identical), wizard prayer accepted result (1D16 -> display-only DieD16), kickoff GateDie duel x2 (DieD6 with «Tirar 1D6 · TÚ/RIVAL» labels). Components gain an optional rollLabel prop (purely additive, pinned per component). Out-of-coverage kept with reasons: Los Hinchas 1D3 (different die — flat glyph byte-identical, boundary-pinned), manual-entry fields (input owns the value; a null DieD6 would lie about an empty face), chips/steppers (closure, rollStepper — not die faces), dock block-face chips (never-touch surface — follow-up). Zero pinned strings touched (L56 verified). Documented behavior delta: migrated sites render the buttonless locked state after recording (stronger than the visible-but-disabled pin; pinned as TRIANGULATE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
T34 (L121) — los visuales de dado de la app migrados a los componentes compartidos:
DieD6(size 40) con «Tirar 1D6» byte-idénticoDieD16(solo display)DieD6con «Tirar 1D6 · TÚ / RIVAL»rollLabel(aditiva) para que todos los strings pineados salgan igualito (L56: cero strings tocados, verificado)Verificación
Risk: none