-
Notifications
You must be signed in to change notification settings - Fork 245
Update info on DNS filtering in automatic proxy mode.md #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
обновить раздел Базы знаний про AdGuard для Android: добавить информацию о DNS-фильтрации в режиме «Автоматический прокси»
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
|
||
:::note | ||
|
||
Please note that DNS filtering will still be active in *Automatic proxy* mode, and your device might not be able to entirely filter out DNS requests from apps. If we compare the situation to VPN mode, apps there are excluded from the local VPN by system means, therefore the system resolver "sees" which apps are included in the VPN and which are not, and either allows them into the local VPN or lets them bypass it. On the other hand, DNS requests come from the system resolver, not from the application. In *Automatic proxy* routing mode, it is only possible to exclude traffic from applications, not their DNS queries — because they are seen by AdGuard as queries from the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a potential wording issue in the note. The phrase 'might not be able to entirely filter out DNS requests from apps' seems to contradict the later explanation that DNS filtering is still active. Consider rewording to 'might not be able to selectively filter out DNS requests from specific apps' to better reflect that DNS filtering works but can't be selectively applied to specific apps in this mode.
Preview was deployed to: https://pull-request-715.kb-adg.pages.dev/ |
Preview was deployed to: https://pull-request-715.kb-adg.pages.dev/ |
Preview was deployed to: https://pull-request-715.kb-adg.pages.dev/ |
Co-authored-by: Helen <[email protected]>
Preview was deployed to: https://pull-request-715.kb-adg.pages.dev/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
Preview was deployed to: https://pull-request-715.kb-adg.pages.dev/ |
обновить раздел Базы знаний про AdGuard для Android: добавить информацию о DNS-фильтрации в режиме «Автоматический прокси»