Skip to content

Commit 1e06bfe

Browse files
Fix caching bug in Nameserver::new()
A nameserver constructed with a name of "0" could be mistakenly cached as having no name, because in Perl, the string "0" is falsey. It’s better to test for string emptyness instead.
1 parent 06d23fb commit 1e06bfe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/Zonemaster/Engine/Nameserver.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ sub new {
7373
if !blessed $attrs->{name} || !$attrs->{name}->isa( 'Zonemaster::Engine::DNSName' );
7474

7575
my $name = lc( q{} . $attrs->{name} );
76-
$name = '$$$NONAME' unless $name;
76+
$name = '$$$NONAME' if $name eq q{};
7777

7878
my $address;
7979

0 commit comments

Comments
 (0)