Address review comments

- Bump Perl version to v5.26
- Use 'my sub { }' syntax
- Update unit test

Author: tgreenx

lib/Zonemaster/CLI.pm

@@ -1,13 +1,13 @@
 # Brief help module to define the exception we use for early exits.
 package Zonemaster::Engine::Exception::NormalExit;
-use 5.014002;
+use v5.26;
 use warnings;
 use parent 'Zonemaster::Engine::Exception';
 
 # The actual interesting module.
 package Zonemaster::CLI;
 
-use 5.014002;
+use v5.26;
 
 use strict;
 use warnings;
@@ -661,7 +661,7 @@ sub run {
         if ( $opt_json ) {
             my @times;
 
-            sub json_nstimes {
+            my sub json_nstimes {
                 my ( $ns ) = @_;
                 return {
                     'ns'      => $ns->string,
@@ -698,7 +698,7 @@ sub run {
             my $total_queries_times = 0;
             my %nss_already_processed;
 
-            sub print_nstimes {
+            my sub print_nstimes {
                 my ( $ns, $max, $total_queries_count, $total_queries_times, $nss_already_processed_ref ) = @_;
                 my %nss_already_processed = %{ $nss_already_processed_ref };
 

t/usage.t

@@ -390,9 +390,15 @@ do {
         text => qr{
             \QLooks OK.\E
             .*
-            Server \s+ Max \s+ Min \s+ Avg \s+ Stddev \s+ Median \s+ Total
+            \QName servers\E \s+ Max \s+ Min \s+ Avg \s+ Stddev \s+ Median \s+ Total \s+ Count
             .*
-            \Qa.root-servers.net/\E
+            \QChild zone\E
+            .*
+            \QParent zone\E
+            .*
+            Other
+            .*
+            \QGrand total\E \s+ \d+
         }msx,
         json => {
             type       => "object",
@@ -401,8 +407,30 @@ do {
                 nstimes => {
                     type  => "array",
                     items => {
-                        type     => "object",
-                        required => [qw( avg max median min ns stddev total)],
+                        type       => "object",
+                        properties => {
+                            child => {
+                                type  => "array",
+                                items => {
+                                    type     => "object",
+                                    required => [qw( avg max median min ns stddev total count)],
+                                },
+                            },
+                            parent => {
+                                type  => "array",
+                                items => {
+                                    type     => "object",
+                                    required => [qw( avg max median min ns stddev total count)],
+                                },
+                            },
+                            other => {
+                                type  => "array",
+                                items => {
+                                    type     => "object",
+                                    required => [qw( avg max median min ns stddev total count)],
+                                },
+                            },
+                        },
                     },
                 },
             },