Skip to content

Commit 9106b15

Browse files
modem: cmux: Decouple modem cmux and cellular driver
The modem modules cmux module is currently directly coupled to the presence of specific modems, rather than being selected by drivers for whatever hardware wants to request the default MTU of 127 bytes. This commit the makes the device drivers (for now, modem_cellular) select the symbol, thus decoupling the modem modules from the presence of any specific device. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
1 parent 5410f74 commit 9106b15

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

drivers/modem/Kconfig.cellular

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ config MODEM_CELLULAR
2121
DT_HAS_QUECTEL_EG25_G_ENABLED || DT_HAS_NORDIC_NRF91_SLM_ENABLED || \
2222
DT_HAS_SQN_GM02S_ENABLED || DT_HAS_U_BLOX_LARA_R6_ENABLED || \
2323
DT_HAS_QUECTEL_EG800Q_ENABLED)
24+
select MODEM_CMUX_DEFAULT_MTU_127 if \
25+
(DT_HAS_QUECTEL_BG95_ENABLED || DT_HAS_QUECTEL_EG25_G_ENABLED || \
26+
DT_HAS_SIMCOM_SIM7080_ENABLED || DT_HAS_U_BLOX_SARA_R4_ENABLED || \
27+
DT_HAS_U_BLOX_SARA_R5_ENABLED || DT_HAS_SWIR_HL7800_ENABLED || \
28+
DT_HAS_TELIT_ME910G1_ENABLED || DT_HAS_TELIT_ME310G1_ENABLED || \
29+
DT_HAS_SQN_GM02S_ENABLED || DT_HAS_QUECTEL_EG800Q_ENABLED || \
30+
DT_HAS_SIMCOM_A76XX_ENABLED)
2431
help
2532
This driver uses the generic 3gpp AT commands, along
2633
with the standard protocols CMUX and PPP, to configure

subsys/modem/Kconfig

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,8 @@ if MODEM_CMUX
3131

3232
config MODEM_CMUX_DEFAULT_MTU_127
3333
bool
34-
default y if (DT_HAS_QUECTEL_BG95_ENABLED || DT_HAS_QUECTEL_EG25_G_ENABLED || \
35-
DT_HAS_SIMCOM_SIM7080_ENABLED || DT_HAS_U_BLOX_SARA_R4_ENABLED || \
36-
DT_HAS_U_BLOX_SARA_R5_ENABLED || DT_HAS_SWIR_HL7800_ENABLED || \
37-
DT_HAS_TELIT_ME910G1_ENABLED || DT_HAS_TELIT_ME310G1_ENABLED || \
38-
DT_HAS_SQN_GM02S_ENABLED || DT_HAS_QUECTEL_EG800Q_ENABLED || \
39-
DT_HAS_SIMCOM_A76XX_ENABLED)
4034
help
41-
Use the default MTU size of 127 bytes for the CMUX module on certain modems.
42-
This must match the AT+CMUX commands in the modem_cellular driver.
35+
Hint that the default MODEM_CMUX_MTU size should be 127 bytes.
4336

4437
config MODEM_CMUX_MTU
4538
int "CMUX MTU size in bytes"

0 commit comments

Comments
 (0)