Skip to content

Commit 4551f3d

Browse files
committed
fix badger setting
1 parent 1d10690 commit 4551f3d

File tree

3 files changed

+28
-26
lines changed

3 files changed

+28
-26
lines changed

pkg/storage/badger/store.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,12 @@ func NewStore(opt Options) storage.Store {
2727
db, err := badger.Open(
2828
badger.DefaultOptions(opt.Path).
2929
WithCompression(options.Snappy).
30-
WithNumLevelZeroTables(1).
31-
WithNumLevelZeroTablesStall(2).
32-
WithNumMemtables(1).
33-
WithValueThreshold(1 << 20))
30+
WithValueThreshold(1 << 10))
3431

3532
if err != nil {
3633
panic(err)
3734
}
38-
35+
err = db.Flatten(10)
3936
s := &store{
4037
db: db,
4138
opt: opt,

pkg/storage/badger/store_test.go

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
package badger
22

33
import (
4+
"fmt"
45
"io/ioutil"
56
"os"
67
"testing"
78
"time"
89

10+
"github.com/dgraph-io/badger/v3/options"
11+
912
"github.com/dgraph-io/badger/v3"
1013
"github.com/stretchr/testify/require"
1114
"github.com/xyctruth/profiler/pkg/storage"
@@ -358,11 +361,7 @@ func BenchmarkBadger1(b *testing.B) {
358361
}
359362
defer os.RemoveAll(dir)
360363

361-
db, err := badger.Open(
362-
badger.DefaultOptions(dir).
363-
WithLoggingLevel(3).
364-
WithBypassLockGuard(true))
365-
364+
db, err := badger.Open(badger.DefaultOptions(dir))
366365
if err != nil {
367366
panic(err)
368367
}
@@ -377,14 +376,19 @@ func BenchmarkBadger1(b *testing.B) {
377376
panic(err)
378377
}
379378

379+
s.metaSeq, err = s.db.GetSequence(MetaSequence, 1000)
380+
if err != nil {
381+
panic(err)
382+
}
383+
380384
defer s.Release()
381385
res, err := os.ReadFile("./trace_119091.gz")
382386
if err != nil {
383387
panic(err)
384388
}
385389

386390
for i := 0; i < b.N; i++ {
387-
_, err = s.SaveProfile("", res, time.Hour*24*7)
391+
_, err = s.SaveProfile(fmt.Sprintf("%d", i), res, time.Hour*24*7)
388392
if err != nil {
389393
panic(err)
390394
}
@@ -400,12 +404,11 @@ func BenchmarkBadger2(b *testing.B) {
400404

401405
db, err := badger.Open(
402406
badger.DefaultOptions(dir).
403-
WithLoggingLevel(3).
404-
WithBypassLockGuard(true).
405-
//WithNumMemtables(1).
406-
//WithNumLevelZeroTables(1).
407-
//WithNumLevelZeroTablesStall(2).
408-
WithValueLogFileSize(64 << 20))
407+
WithCompression(options.Snappy).
408+
WithNumLevelZeroTables(1).
409+
WithNumLevelZeroTablesStall(2).
410+
WithNumMemtables(1).
411+
WithValueThreshold(1 << 20))
409412

410413
if err != nil {
411414
panic(err)
@@ -421,14 +424,19 @@ func BenchmarkBadger2(b *testing.B) {
421424
panic(err)
422425
}
423426

427+
s.metaSeq, err = s.db.GetSequence(MetaSequence, 1000)
428+
if err != nil {
429+
panic(err)
430+
}
431+
424432
defer s.Release()
425433
res, err := os.ReadFile("./trace_119091.gz")
426434
if err != nil {
427435
panic(err)
428436
}
429437

430438
for i := 0; i < b.N; i++ {
431-
_, err = s.SaveProfile("", res, time.Hour*24*7)
439+
_, err = s.SaveProfile(fmt.Sprintf("%d", i), res, time.Hour*24*7)
432440
if err != nil {
433441
panic(err)
434442
}

pkg/storage/badger/ttl_test.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,18 @@ func TestTTL(t *testing.T) {
1010
// err := os.Mkdir(dir, 0777)
1111
// require.Equal(t, nil, err)
1212
//}
13-
//s := NewStore(DefaultOptions(dir))
14-
//
15-
////for i := 0; true; i++ {
16-
//// a, s, err := s.GetProfile(fmt.Sprintf("%d", i))
17-
//// fmt.Sprintln(a, s, err)
18-
////}
19-
//
13+
//s := NewStore(DefaultOptions(dir).WithGCInternal(time.Second * 10))
2014
//for i := 0; true; i++ {
2115
// res, err := os.ReadFile("./trace_119091.gz")
2216
// if err != nil {
2317
// panic(err)
2418
// }
25-
// s, err := s.SaveProfile(fmt.Sprintf("%d", i), res, 10*time.Second)
19+
// s, err := s.SaveProfile(fmt.Sprintf("%d", i), res, 1*time.Minute)
2620
// if err != nil {
2721
// fmt.Println(s, err)
2822
// }
23+
// if i%1000 == 0 {
24+
// time.Sleep(time.Second * 10)
25+
// }
2926
//}
3027
}

0 commit comments

Comments
 (0)