-
Notifications
You must be signed in to change notification settings - Fork 12
Switch to windows-2022 build server and winrt #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR migrates the Windows input module to use the winrt package, upgrades Windows CI runners to windows-2022, bumps testing and build workflows to Python 3.12, and locks project compatibility to ≥3.11,<3.13. Class diagram for winmedia.py Windows media imports migrationclassDiagram
class winmedia
class MediaManager
class DataReader
class Buffer
class InputStreamOptions
winmedia ..> MediaManager : uses
winmedia ..> DataReader : uses
winmedia ..> Buffer : uses
winmedia ..> InputStreamOptions : uses
note for winmedia "Imports now from winrt.windows.* instead of winsdk.windows.*"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
01c0557
to
e29d988
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 68.25% 68.25%
=======================================
Files 63 63
Lines 10969 10969
=======================================
Hits 7487 7487
Misses 3482 3482
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aw-was-here - I've reviewed your changes - here's some feedback:
- Ensure the winrt package is added to your runtime dependencies so those new imports won’t break in CI or production.
- Consider extracting the repeated Python setup steps across your workflows into a reusable action to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the winrt package is added to your runtime dependencies so those new imports won’t break in CI or production.
- Consider extracting the repeated Python setup steps across your workflows into a reusable action to reduce duplication.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update continuous integration to Python 3.12 and modern Windows runners, enforce Python version bounds, and migrate Windows media control imports to the WinRT API.
Enhancements:
Build:
CI: