Skip to content

Changes required to build under macos 10.14 #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Changes required to build under macos 10.14 #1212

merged 1 commit into from
Jun 29, 2025

Conversation

aw-was-here
Copy link
Collaborator

@aw-was-here aw-was-here commented Jun 29, 2025

Summary by Sourcery

Enable building under macOS 10.14 by extracting binary dependencies into a separate optional group and updating the installer to use it.

Build:

  • Introduce a new “binaries” optional dependency group backed by requirements-binaries.txt
  • Update builder.sh to install the binaries extra instead of the dev group for binary dependencies

Copy link

sourcery-ai bot commented Jun 29, 2025

Reviewer's Guide

Adds a dedicated “binaries” optional-dependency group for macOS builds by updating pyproject.toml, supplying its own requirements file, and adjusting the build script to install it.

Class diagram for updated optional dependencies in pyproject.toml

classDiagram
    class OptionalDependencies {
        +binaries: requirements-binaries.txt
        +dev: requirements-dev.txt
        +docs: docs/requirements.txt
        +osspecials: requirements-osspecials.txt
        +test: requirements-test.txt
    }
Loading

File-Level Changes

Change Details Files
Define a new “binaries” optional dependency group in pyproject.toml
  • Added “binaries” group referencing requirements-binaries.txt
  • Reorganized existing optional groups around the new entry
pyproject.toml
Include “binaries” in the builder script installation command
  • Replaced “dev” with “binaries” in pip install arguments
  • Preserved installation of “osspecials” dependencies
builder.sh
Add macOS-specific binaries requirements file
  • Created requirements-binaries.txt to list binary dependencies
requirements-binaries.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aw-was-here - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@aw-was-here
Copy link
Collaborator Author

These changes should fix #966 as well.

@aw-was-here aw-was-here merged commit 7b30781 into main Jun 29, 2025
12 checks passed
@aw-was-here aw-was-here deleted the macos1014 branch June 29, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant