Skip to content

switch to macos-latest #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

switch to macos-latest #1110

merged 2 commits into from
Dec 23, 2024

Conversation

aw-was-here
Copy link
Collaborator

@aw-was-here aw-was-here commented Dec 23, 2024

Summary by Sourcery

CI:

  • Use macos-latest instead of macos-12.

Copy link

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This pull request switches the macOS runner from macos-12 to macos-latest.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Use macos-latest runner
  • Changed runs-on from macos-12 to macos-latest in testing and pyinstaller workflows.
  • Renamed the artifacts from macos-12-* to macos-* and macos-latest-*.
  • Updated the needs section of the merge job to depend on the renamed testing job name for macOS.
.github/workflows/testing.yaml
.github/workflows/pyinstaller.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.44%. Comparing base (ce6be0f) to head (ce7ff10).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
+ Coverage   61.79%   62.44%   +0.65%     
==========================================
  Files          45       44       -1     
  Lines        7519     7338     -181     
==========================================
- Hits         4646     4582      -64     
+ Misses       2873     2756     -117     
Flag Coverage Δ
unittests 62.44% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aw-was-here aw-was-here merged commit cd45017 into main Dec 23, 2024
14 checks passed
@aw-was-here aw-was-here deleted the macos-test branch December 23, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant