fixes

Author: aw-was-here

nowplaying/processes/trackpoll.py

@@ -382,14 +382,20 @@ def _write_to_text(self):
                                                     templatehandler=self.txttemplatehandler,
                                                     metadata=self.currentmeta)
 
-    def _strip_blobs_metadata(self, metadata: TrackMetadata) -> TrackMetadata:
+    @staticmethod
+    def _strip_blobs_metadata(metadata: TrackMetadata) -> TrackMetadata:
         ''' Strip binary blob data for remote transmission '''
         remote_data = metadata.copy()
 
         # Remove all blob fields
         for key in nowplaying.db.METADATABLOBLIST:
             remote_data.pop(key, None)
 
+        for key, value in remote_data.items():
+            if isinstance(value, bytes):
+                logging.error("%s was dropped from remote_data (bytes)", key)
+                remote_data.pop(key, None)
+
         # Remove dbid if present
         if remote_data.get('dbid'):
             del remote_data['dbid']
@@ -411,10 +417,10 @@ async def _write_to_remote(self) -> None:
         # Debug: write JSON to file to inspect
         try:
             debug_file = '/tmp/remote_debug.json'
-            with open(debug_file, 'w', encoding='utf-8') as f:
-                json.dump(remote_data, f, indent=2)
+            with open(debug_file, 'w', encoding='utf-8') as fnout:
+                json.dump(remote_data, fnout, indent=2)
             logging.info('Debug: wrote remote data to %s', debug_file)
-        except Exception as exc:  # pylint: disable=broad-except
+        except Exception:  # pylint: disable=broad-except
             logging.exception('Failed to write debug JSON: %s')
 
         async with aiohttp.ClientSession() as session:

tests/test_remote.py

@@ -159,9 +159,9 @@ async def test_remote_plugin_getplayingtrack(remote_bootstrap):  # pylint: disab
     test_metadata = {'artist': 'Test Artist', 'title': 'Test Title', 'filename': 'test.mp3'}
     plugin.metadata = test_metadata
 
-    with patch.object(plugin, 'start') as mock_start:
+    # Mock the database initialization in start() to avoid actual file operations
+    with patch('nowplaying.db.MetadataDB'), patch('nowplaying.db.DBWatcher'):
         result = await plugin.getplayingtrack()
-        mock_start.assert_called_once()
         assert result == test_metadata
 
 
@@ -301,8 +301,10 @@ async def test_remote_plugin_config_missing_remotedb(bootstrap):
 
     plugin = nowplaying.inputs.remote.Plugin(config=config)
 
-    # Should handle missing config gracefully
-    assert plugin.remotedbfile is None or plugin.remotedbfile == ''
+    # Plugin now sets a default path via defaults() method
+    # So remotedbfile should contain a valid path, not be None/empty
+    assert plugin.remotedbfile is not None
+    assert 'remote.db' in plugin.remotedbfile
 
 
 @pytest.mark.asyncio