fixes

Author: aw-was-here

nowplaying/db.py

@@ -180,6 +180,9 @@ def filterkeys(mydict: dict[str, Any]) -> dict[str, Any]:
             return {key: mydict[key] for key in METADATALIST + METADATABLOBLIST if key in mydict}
 
         logging.debug('Called (async) write_to_metadb')
+        if metadata is None:
+            logging.debug('metadata is None')
+            return
         if (not metadata or not METADATALIST or 'title' not in metadata
                 or 'artist' not in metadata):
             logging.debug('metadata is either empty or too incomplete')

nowplaying/imagecache.py

@@ -613,7 +613,8 @@ def _get_next_queue_batch(self, recently_processed: dict[str, float]) -> list[di
 
         return batch
 
-    def _cleanup_queue_tracking(self, recently_processed: dict[str, float]) -> None:
+    @staticmethod
+    def _cleanup_queue_tracking(recently_processed: dict[str, float]) -> None:
         """Remove entries older than 3 minutes from queue processing tracking."""
         current_time = time.time()
         expired_keys = [

nowplaying/inputs/m3u.py

@@ -25,7 +25,7 @@
 # https://datatracker.ietf.org/doc/html/rfc8216
 
 
-class Plugin(InputPlugin):
+class Plugin(InputPlugin):  # pylint: disable=too-many-instance-attributes
     ''' handler for NowPlaying '''
 
     def __init__(self, config=None, m3udir=None, qsettings=None):
@@ -38,7 +38,6 @@ def __init__(self, config=None, m3udir=None, qsettings=None):
 
         self.mixmode = "newest"
         self.event_handler = None
-        # Instance variable instead of class variable to prevent test interference
         self.metadata: dict[str, str | None] = {'artist': None, 'title': None, 'filename': None}
         self.observer = None
         self._reset_meta()

nowplaying/utils.py

@@ -61,7 +61,7 @@ def safe_stopevent_check(stopevent: asyncio.Event|None) -> bool:
     """
     try:
         return stopevent.is_set()
-    except (BrokenPipeError, EOFError):
+    except (BrokenPipeError, EOFError, AttributeError):
         # Expected shutdown errors - pipe closed before subprocess finished
         logging.debug("Shutdown pipe error detected, treating as stop signal")
         return True