Little bit of refactoring

Just trying to keep that testability

Author: tkellogg

Jump.Location.Specs/DirectoryWaitPeriodSpec.cs

@@ -1,4 +1,5 @@
 using System;
+using Moq;
 using Xunit;
 using Should;
 
@@ -10,18 +11,17 @@ public class DirectoryWaitPeriodSpec
         public void It_updates_the_records_weight_upon_CloseAndUpdate()
         {
             var now = DateTime.Now.AddMinutes(-3);
-            var record = new Record("x::y", 0);
-            var waitPeriod = new DirectoryWaitPeriod(record, now);
+            var recordMock = new Mock<IRecord>();
+            var waitPeriod = new DirectoryWaitPeriod(recordMock.Object, now);
 
             waitPeriod.CloseAndUpdate();
-
-            Assert.True(record.Weight > 0);
+            recordMock.Verify(x => x.AddTimeSpent(It.IsAny<TimeSpan>()));
         }
 
         [Fact]
         public void You_cant_call_CloseAndUpdate_twice()
         {
-            var waitPeriod = new DirectoryWaitPeriod(new Record("x::y", 0), DateTime.Now);
+            var waitPeriod = new DirectoryWaitPeriod(Mock.Of<IRecord>(), DateTime.Now);
             waitPeriod.CloseAndUpdate();
             Assert.Throws<InvalidOperationException>(() => waitPeriod.CloseAndUpdate());
         }

Jump.Location.Specs/Jump.Location.Specs.csproj

@@ -32,6 +32,9 @@
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>
   <ItemGroup>
+    <Reference Include="Moq">
+      <HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
+    </Reference>
     <Reference Include="Should">
       <HintPath>..\packages\Should.1.1.12.0\lib\Should.dll</HintPath>
     </Reference>

Jump.Location.Specs/packages.config

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
+  <package id="Moq" version="4.0.10827" />
   <package id="Should" version="1.1.12.0" />
   <package id="xunit" version="1.9.1" />
   <package id="xunit.extensions" version="1.9.1" />

Jump.Location/DirectoryWaitPeriod.cs

@@ -4,11 +4,11 @@ namespace Jump.Location
 {
     class DirectoryWaitPeriod
     {
-        private readonly Record record;
+        private readonly IRecord record;
         private readonly DateTime startTime;
         private bool hasDestroyed;
 
-        public DirectoryWaitPeriod(Record record, DateTime now)
+        public DirectoryWaitPeriod(IRecord record, DateTime now)
         {
             this.record = record;
             startTime = now;
@@ -18,9 +18,7 @@ public void CloseAndUpdate()
         {
             if (hasDestroyed) throw new InvalidOperationException("You can't call CloseAndUpdate multiple times");
 
-            var seconds = (DateTime.Now - startTime).TotalSeconds;
-            record.Weight += (decimal) seconds;
-
+            record.AddTimeSpent(DateTime.Now - startTime);
             hasDestroyed = true;
         }
     }

Jump.Location/Record.cs

@@ -2,7 +2,16 @@
 
 namespace Jump.Location
 {
-    class Record
+    public interface IRecord
+    {
+        string Provider { get; }
+        string Path { get; }
+        string FullName { get; set; }
+        decimal Weight { get; }
+        void AddTimeSpent(TimeSpan timeSpan);
+    }
+
+    class Record : IRecord
     {
         public Record(string fullName, decimal weight)
         {
@@ -28,6 +37,11 @@ public string FullName
             }
         }
 
-        public decimal Weight { get; set; }
+        public decimal Weight { get; private set; }
+
+        public void AddTimeSpent(TimeSpan timeSpan)
+        {
+            Weight += (decimal) timeSpan.TotalSeconds;
+        }
     }
 }