Switch to standardrb for linting

Author: little9

.gitignore

@@ -8,4 +8,5 @@ vendor
 Gemfile.lock
 .bundle
 .project
-.idea
+.idea
+coverage

.rubocop.yml

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec

Gemfile

@@ -1,24 +1,19 @@
 # frozen_string_literal: true
 
-require 'rubygems'
-require 'bundler/setup'
+require "rubygems"
+require "bundler/setup"
 Bundler.setup(:default, :development, :test)
 
-require 'rake'
-require 'rdoc/task'
-require 'rspec/core/rake_task'
-require 'rubocop/rake_task'
+require "rake"
+require "rdoc/task"
+require "rspec/core/rake_task"
+require "standard/rake"
 
 Bundler::GemHelper.install_tasks
 
-desc 'Run rubocop'
-task rubocop: :environment do
-  RuboCop::RakeTask.new
-end
-
 RSpec::Core::RakeTask.new do |t|
-  t.pattern = 'spec/**/*_spec.rb'
+  t.pattern = "spec/**/*_spec.rb"
   t.rspec_opts = %w[--format documentation --color]
 end
 
-task default: [:rubocop, :spec]
+task default: [:standard, :spec]

Rakefile

@@ -1,35 +1,34 @@
-# coding: utf-8
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'bagit/version'
+require "bagit/version"
 
 Gem::Specification.new do |spec|
-  spec.name        = "bagit"
-  spec.version     = BagIt::VERSION
-  spec.summary     = "BagIt package generation and validation"
+  spec.name = "bagit"
+  spec.version = BagIt::VERSION
+  spec.summary = "BagIt package generation and validation"
   spec.description = "Ruby Library and Command Line tools for bagit"
-  spec.email       = "[email protected]"
-  spec.homepage    = 'http://github.com/tipr/bagit'
-  spec.authors     = ["Tom Johnson, Francesco Lazzarino, Jamie Little"]
-  spec.license     = "MIT"
+  spec.email = "[email protected]"
+  spec.homepage = "http://github.com/tipr/bagit"
+  spec.authors = ["Tom Johnson, Francesco Lazzarino, Jamie Little"]
+  spec.license = "MIT"
 
-  spec.required_ruby_version = '~> 2.0'
+  spec.required_ruby_version = "~> 2.0"
 
-  spec.add_dependency 'validatable', '~> 1.6'
-  spec.add_dependency 'docopt', '~> 0.5.0'
+  spec.add_dependency "validatable", "~> 1.6"
+  spec.add_dependency "docopt", "~> 0.5.0"
 
-  spec.add_development_dependency 'bixby'
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'coveralls'
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'pry-byebug'
-  spec.add_development_dependency 'rake', '>= 12.3.3'
-  spec.add_development_dependency 'rspec', '~> 3'
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "coveralls"
+  spec.add_development_dependency "pry"
+  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "rake", ">= 12.3.3"
+  spec.add_development_dependency "rspec", "~> 3"
+  spec.add_development_dependency "standard"
 
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 end

bagit.gemspec

@@ -5,12 +5,12 @@
 # Functionality conforms to the BagIt Spec v0.96:
 # http://www.cdlib.org/inside/diglib/bagit/bagitspec.html
 
-require 'bagit/bag'
-require 'bagit/version'
-require 'fileutils'
-require 'date'
-require 'logger'
+require "bagit/bag"
+require "bagit/version"
+require "fileutils"
+require "date"
+require "logger"
 module BagIt
   # The version of the BagIt specification the code is conforming to.
-  SPEC_VERSION = '0.97'
+  SPEC_VERSION = "0.97"
 end

lib/bagit.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-require 'bagit/fetch'
-require 'bagit/file'
-require 'bagit/info'
-require 'bagit/manifest'
-require 'bagit/string'
-require 'bagit/valid'
+require "bagit/fetch"
+require "bagit/file"
+require "bagit/info"
+require "bagit/manifest"
+require "bagit/string"
+require "bagit/valid"
 
 module BagIt
   # Represents the state of a bag on a filesystem
   class Bag
     attr_reader :bag_dir
 
-    include Validity            # Validity functionality
-    include Info                # bagit & bag info functionality
-    include Manifest            # manifest related functionality
-    include Fetch               # fetch related functionality
+    include Validity # Validity functionality
+    include Info # bagit & bag info functionality
+    include Manifest # manifest related functionality
+    include Fetch # fetch related functionality
 
     # Make a new Bag based at path
     def initialize(path, info = {}, _create = false)
@@ -32,20 +32,20 @@ def initialize(path, info = {}, _create = false)
 
     # Return the path to the data directory
     def data_dir
-      File.join @bag_dir, 'data'
+      File.join @bag_dir, "data"
     end
 
     # Return the paths to each bag file relative to bag_dir
     def bag_files
-      Dir[File.join(data_dir, '**', '*')].select { |f| File.file? f }
+      Dir[File.join(data_dir, "**", "*")].select { |f| File.file? f }
     end
 
     # Return the paths to each tag file relative to bag_dir
     def tag_files
       files = []
       if tagmanifest_files != []
         File.open(tagmanifest_files.first) do |f|
-          f.each_line { |line| files << File.join(@bag_dir, line.split(' ')[1]) }
+          f.each_line { |line| files << File.join(@bag_dir, line.split(" ")[1]) }
         end
       end
       files
@@ -58,10 +58,10 @@ def add_file(relative_path, src_path = nil)
       FileUtils.mkdir_p File.dirname(path)
 
       f = if src_path.nil?
-            File.open(path, 'w') { |io| yield io }
-          else
-            FileUtils.cp src_path, path
-          end
+        File.open(path, "w") { |io| yield io }
+      else
+        FileUtils.cp src_path, path
+      end
       write_bag_info
       f
     end
@@ -88,7 +88,7 @@ def empty?
 
     # Get all bag file paths relative to the data dir
     def paths
-      bag_files.collect { |f| f.sub(data_dir + '/', '') }
+      bag_files.collect { |f| f.sub(data_dir + "/", "") }
     end
 
     # Get the Oxum for the payload files
@@ -98,7 +98,7 @@ def payload_oxum
         # TODO: filesystem quirks? Are we getting the stream size or the size on disk?
         bytes += File.size(f)
       end
-      bytes.to_s + '.' + bag_files.count.to_s
+      bytes.to_s + "." + bag_files.count.to_s
     end
 
     # Remove all empty directory trees from the bag

lib/bagit/bag.rb

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
-require 'open-uri'
+require "open-uri"
 
 module BagIt
   module Fetch
     def fetch_txt_file
-      File.join @bag_dir, 'fetch.txt'
+      File.join @bag_dir, "fetch.txt"
     end
 
     def add_remote_file(url, path, size, sha1, md5)
-      open(fetch_txt_file, 'a') { |io| io.puts "#{url} #{size || '-'} #{path}" }
-      open(manifest_file('sha1'), 'a') { |io| io.puts "#{sha1} #{File.join 'data', path}" }
-      open(manifest_file('md5'), 'a') { |io| io.puts "#{md5} #{File.join 'data', path}" }
+      File.open(fetch_txt_file, "a") { |io| io.puts "#{url} #{size || "-"} #{path}" }
+      File.open(manifest_file("sha1"), "a") { |io| io.puts "#{sha1} #{File.join "data", path}" }
+      File.open(manifest_file("md5"), "a") { |io| io.puts "#{md5} #{File.join "data", path}" }
     end
 
     # feth all remote files
     def fetch!
-      open(fetch_txt_file) do |io|
+      File.open(fetch_txt_file) do |io|
         io.readlines.each do |line|
           (url, _length, path) = line.chomp.split(/\s+/, 3)
 
           add_file(path) do |file_io|
-            file_io.write open(url)
+            file_io.write URI.open(url)
           end
         end
       end

lib/bagit/fetch.rb

@@ -1,29 +1,29 @@
 # frozen_string_literal: true
 
-require 'set'
+require "set"
 
 module BagIt
   module Info
     @@bag_info_headers = {
-      agent: 'Bag-Software-Agent',
-      org: 'Source-Organization',
-      org_addr: 'Organization-Address',
-      contact_name: 'Contact-Name',
-      contact_phone: 'Contact-Phone',
-      contact_email: 'Contact-Email',
-      ext_desc: 'External-Description',
-      ext_id: 'External-Identifier',
-      size: 'Bag-Size',
-      group_id: 'Bag-Group-Identifier',
-      group_count: 'Bag-Count',
-      sender_id: 'Internal-Sender-Identifier',
-      int_desc: 'Internal-Sender-Description',
-      date: 'Bagging-Date',
-      oxum: 'Payload-Oxum'
+      agent: "Bag-Software-Agent",
+      org: "Source-Organization",
+      org_addr: "Organization-Address",
+      contact_name: "Contact-Name",
+      contact_phone: "Contact-Phone",
+      contact_email: "Contact-Email",
+      ext_desc: "External-Description",
+      ext_id: "External-Identifier",
+      size: "Bag-Size",
+      group_id: "Bag-Group-Identifier",
+      group_count: "Bag-Count",
+      sender_id: "Internal-Sender-Identifier",
+      int_desc: "Internal-Sender-Description",
+      date: "Bagging-Date",
+      oxum: "Payload-Oxum"
     }
 
     def bag_info_txt_file
-      File.join bag_dir, 'bag-info.txt'
+      File.join bag_dir, "bag-info.txt"
     end
 
     def bag_info
@@ -35,13 +35,13 @@ def bag_info
     def write_bag_info(hash = {})
       hash = bag_info.merge(hash)
       hash[@@bag_info_headers[:agent]] = "BagIt Ruby Gem (https://github.com/tipr/bagit)" if hash[@@bag_info_headers[:agent]].nil?
-      hash[@@bag_info_headers[:date]] = Date.today.strftime('%Y-%m-%d') if hash[@@bag_info_headers[:date]].nil?
+      hash[@@bag_info_headers[:date]] = Date.today.strftime("%Y-%m-%d") if hash[@@bag_info_headers[:date]].nil?
       hash[@@bag_info_headers[:oxum]] = payload_oxum
       write_info_file bag_info_txt_file, hash
     end
 
     def bagit_txt_file
-      File.join bag_dir, 'bagit.txt'
+      File.join bag_dir, "bagit.txt"
     end
 
     def bagit
@@ -53,7 +53,7 @@ def write_bagit(hash)
     end
 
     def update_bag_date
-      hash["Bagging-Date"] = Date.today.strftime('%Y-%m-%d')
+      hash["Bagging-Date"] = Date.today.strftime("%Y-%m-%d")
       write_bag_info(hash)
     end
 
@@ -71,22 +71,22 @@ def read_info_file(file)
     end
 
     def write_info_file(file, hash)
-      dups = hash.keys.inject(Set.new) do |acc, key|
+      dups = hash.keys.inject(Set.new) { |acc, key|
         a = hash.keys.grep(/#{key}/i)
         acc + (a.size > 1 ? a : [])
-      end
+      }
 
-      raise "Multiple labels (#{dups.to_a.join ', '}) in #{file}" unless dups.empty?
+      raise "Multiple labels (#{dups.to_a.join ", "}) in #{file}" unless dups.empty?
 
-      File.open(file, 'w') do |io|
+      File.open(file, "w") do |io|
         hash.each do |name, value|
-          simple_entry = "#{name}: #{value.gsub(/\s+/, ' ')}"
+          simple_entry = "#{name}: #{value.gsub(/\s+/, " ")}"
 
           entry = if simple_entry.length > 79
-                    simple_entry.wrap(77).indent(2)
-                  else
-                    simple_entry
-                  end
+            simple_entry.wrap(77).indent(2)
+          else
+            simple_entry
+          end
 
           io.puts entry
         end