Fix breakage from v0.3.38

Author: jhpratt

.github/workflows/build.yaml

@@ -18,6 +18,9 @@ env:
     "x86_64-unknown-linux-gnu",
     "x86_64-apple-darwin",
     "x86_64-pc-windows-gnu"
+    ],
+    "wasm": [
+    "wasm32-unknown-unknown"
     ]
     }'
 
@@ -58,22 +61,32 @@ jobs:
             query: .no_std + .std_no_offset + .std_with_offset
             exclude-features:
               - std
+              - wasm-bindgen
               - formatting
               - serde-human-readable
               - serde-well-known
               - local-offset
               - quickcheck
-            group-features: []
+            group-features:
+              - [serde, rand]
           - name: std_no_offset
             query: .std_no_offset + .std_with_offset
-            exclude-features: [local-offset]
+            exclude-features: [wasm-bindgen, local-offset]
             enable-features: [std]
             group-features:
+              - [serde, rand]
               - [formatting, parsing]
               - [serde-human-readable, serde-well-known]
           - name: std_with_offset
             query: .std_with_offset
-            enable-features: [std, local-offset]
+            enable-features: [wasm-bindgen, std, local-offset]
+            group-features:
+              - [serde, rand]
+              - [formatting, parsing]
+              - [serde-human-readable, serde-well-known]
+          - name: wasm
+            query: .wasm
+            exclude-features: [rand, quickcheck, local-offset]
             group-features:
               - [formatting, parsing]
               - [serde-human-readable, serde-well-known]
@@ -115,8 +128,7 @@ jobs:
           --no-dev-deps \
           --feature-powerset \
           --optional-deps \
-          --group-features serde,rand \
-          --exclude-features default,wasm-bindgen,${{ join(matrix.kind.exclude-features) }} \
+          --exclude-features default,${{ join(matrix.kind.exclude-features) }} \
           --features macros,${{ join(matrix.kind.enable-features) }} \
           --exclude-all-features \
           )
@@ -169,6 +181,25 @@ jobs:
       - name: Test
         run: cargo test -p time --all-features
 
+  test-docs:
+    name: Test (docs)
+    runs-on: ubuntu-latest
+    if: (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) || github.event_name == 'push'
+
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v4
+
+      - name: Cache cargo output
+        uses: Swatinem/rust-cache@v2
+
+      - name: Install toolchain
+        uses: dtolnay/rust-toolchain@stable
+
+      # Test with default feature set to prevent #735 from happening again.
+      - name: Doc test
+        run: cargo test -p time --doc
+
   miri:
     name: Test (miri)
     runs-on: ubuntu-latest

.github/workflows/powerset.yaml

@@ -22,6 +22,9 @@ env:
     "x86_64-linux-android",
     "x86_64-unknown-netbsd",
     "x86_64-unknown-illumos"
+    ],
+    "wasm": [
+    "wasm32-unknown-unknown"
     ]
     }'
 
@@ -56,18 +59,23 @@ jobs:
             query: .no_std + .std_no_offset + .std_with_offset
             exclude_features:
               - std
+              - wasm-bindgen
               - local-offset
               - quickcheck
               - formatting
               - serde-human-readable
               - serde-well-known
           - name: std_no_offset
             query: .std_no_offset + .std_with_offset
-            exclude_features: [local-offset]
+            exclude_features: [local-offset, wasm-bindgen]
             enable_features: [std]
           - name: std_with_offset
             query: .std_with_offset
+            exclude_features: [wasm-bindgen]
             enable_features: [std, local-offset]
+          - name: wasm
+            query: .wasm
+            exclude_features: [rand, quickcheck, local-offset]
 
     steps:
       - name: Checkout sources
@@ -97,7 +105,7 @@ jobs:
           --no-dev-deps \
           --feature-powerset \
           --optional-deps \
-          --exclude-features default,wasm-bindgen,${{ join(matrix.kind.exclude_features) }} ${{
+          --exclude-features default,${{ join(matrix.kind.exclude_features) }} ${{
           matrix.kind.enable_features && format('--features {0}', join(matrix.kind.enable_features)) }}
 
   release:

time/src/offset_date_time.rs

@@ -269,7 +269,14 @@ impl OffsetDateTime {
     ///     1999,
     /// );
     /// assert_eq!(
-    ///     datetime!(+999999-12-31 23:59:59 -1).checked_to_utc(),
+    #[cfg_attr(
+        feature = "large-dates",
+        doc = "    datetime!(+999999-12-31 23:59:59 -1).checked_to_utc(),"
+    )]
+    #[cfg_attr(
+        not(feature = "large-dates"),
+        doc = "    datetime!(9999-12-31 23:59:59 -1).checked_to_utc(),"
+    )]
     ///     None,
     /// );
     /// ```

time/src/utc_date_time.rs

@@ -1404,6 +1404,8 @@ impl From<js_sys::Date> for UtcDateTime {
 ))]
 impl From<UtcDateTime> for js_sys::Date {
     fn from(datetime: UtcDateTime) -> Self {
+        use num_conv::prelude::*;
+
         // new Date() takes milliseconds
         let timestamp = (datetime.unix_timestamp_nanos()
             / Nanosecond::per(Millisecond).cast_signed().extend::<i128>())