Skip to content

Commit 771fedc

Browse files
Replace commonmarker with Redcarpet::Markdown (#337)
**This PR:** - Replaces [commonmarker](https://github.com/gjtorikian/commonmarker) with [redcarpet](https://github.com/vmg/redcarpet) - Simplifies the output of `rspec` to only show failures and not display the details of every test Dependabot wants to upgrade `commonmarker` to a [version after 1.0](#336) but the latest version doesn't work because of [this issue](github/markup#1758). Redcarpet renders the example app documentation correctly without any additional code changes.
1 parent e0a3519 commit 771fedc

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.rspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
--format documentation
21
--color
32
--require spec_helper

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ gem "rails"
99

1010
gem "bootsnap", ">= 1.4.4", require: false
1111
gem "bourbon"
12-
gem "commonmarker", "< 1.0"
1312
gem "github-markup", require: "github/markup"
1413
gem "jsbundling-rails"
1514
gem "pg", ">= 0.18", "< 2.0"
1615
gem "puma", "~> 6.0"
16+
gem "redcarpet"
1717
gem "sass-rails", ">= 6"
1818
gem "sentry-raven"
1919
gem "themoviedb-api"

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ GEM
102102
regexp_parser (>= 1.5, < 3.0)
103103
xpath (~> 3.2)
104104
coderay (1.1.3)
105-
commonmarker (0.23.10)
106105
concurrent-ruby (1.3.4)
107106
connection_pool (2.4.1)
108107
crass (1.0.6)
@@ -234,6 +233,7 @@ GEM
234233
ffi (~> 1.0)
235234
rdoc (6.7.0)
236235
psych (>= 4.0.0)
236+
redcarpet (3.6.0)
237237
regexp_parser (2.9.2)
238238
reline (0.5.9)
239239
io-console (~> 0.5)
@@ -332,7 +332,6 @@ DEPENDENCIES
332332
bundler (~> 2.3)
333333
byebug
334334
capybara (>= 3.26)
335-
commonmarker (< 1.0)
336335
dotenv-rails
337336
factory_bot_rails
338337
github-markup
@@ -343,6 +342,7 @@ DEPENDENCIES
343342
puma (~> 6.0)
344343
rails
345344
rake (~> 13.0)
345+
redcarpet
346346
rspec (~> 3.0)
347347
rspec-rails
348348
rspec_junit_formatter (~> 0.4)

0 commit comments

Comments
 (0)