Skip to content

Commit 6e36bfd

Browse files
Update doctrine/coding-standard requirement from ^12.0 to ^12.0 || ^13.0 (#741)
* Update doctrine/coding-standard requirement from ^12.0 to ^12.0 || ^13.0 Updates the requirements on [doctrine/coding-standard](https://github.com/doctrine/coding-standard) to permit the latest version. - [Release notes](https://github.com/doctrine/coding-standard/releases) - [Commits](doctrine/coding-standard@12.0.0...13.0.0) --- updated-dependencies: - dependency-name: doctrine/coding-standard dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Run PHPCS on the target PHP version * Specify phpcs vendor/bin path * Only run CS checks on the minimum supported version * Resolve duplicate code coverage artifact name collision --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob Thomason <[email protected]>
1 parent f99dfb8 commit 6e36bfd

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/workflows/continuous_integration.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,21 +74,22 @@ jobs:
7474
- name: "Run static code analysis with phpstan/phpstan"
7575
run: "composer phpstan"
7676

77-
- name: "Run coding standard checks with squizlabs/php_codesniffer"
78-
run: "composer cs-check"
77+
- name: "Run coding standard checks with squizlabs/php_codesniffer on minimum supported PHP version"
78+
if: matrix.php-version == '8.1'
79+
run: composer cs-check
7980

8081
- name: "Archive code coverage results"
8182
uses: actions/upload-artifact@v4
8283
with:
83-
name: codeCoverage-${{ matrix.php-version }}
84+
name: codeCoverage-${{ matrix.php-version }}-${{ github.run_id }}
8485
path: "build"
8586
overwrite: true
8687

8788
- uses: codecov/[email protected] # upload the coverage to codecov
8889
with:
8990
fail_ci_if_error: false # optional (default = false) - Need CODECOV_TOKEN
90-
# Do not upload in forks, and only on php8.3, latest deps
91-
if: ${{ github.repository == 'thecodingmachine/graphqlite' && matrix.php-version == '8.3' && matrix.install-args == '' }}
91+
# Do not upload in forks, and only on php8.4, latest deps
92+
if: ${{ github.repository == 'thecodingmachine/graphqlite' && matrix.php-version == '8.4' && matrix.install-args == '' }}
9293

9394
examples:
9495
name: Check Examples
@@ -103,7 +104,7 @@ jobs:
103104
- name: "Install PHP with extensions"
104105
uses: "shivammathur/setup-php@v2"
105106
with:
106-
php-version: "8.2"
107+
php-version: "8.4"
107108
tools: composer:v2
108109
- name: "Install dependencies with composer"
109110
working-directory: "examples/${{ matrix.example }}"

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
},
2929
"require-dev": {
3030
"beberlei/porpaginas": "^2.0",
31-
"doctrine/coding-standard": "^12.0",
31+
"doctrine/coding-standard": "^12.0 || ^13.0",
3232
"ecodev/graphql-upload": "^7.0",
3333
"laminas/laminas-diactoros": "^3.5",
3434
"myclabs/php-enum": "^1.6.6",

0 commit comments

Comments
 (0)