Fix archivePathToZip cache and FoundFile #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1mlange
force-pushed
the
fix/foundfile
branch
from
7c11421 to
538c5f4
Compare
The old implementation had multiple issues. First, the reference counting was exposed to the user, and surprise, it was not used correctly. Second, with correct reference counting, the cache did not evict unused but instead returned also already closed resources. And last, even if both issues are fixed, the reference count needs to be performed with the cache eviction, otherwise one might acquire the resource in between the decrement and eviction. This patch tries to keep track of shared resources transparently. Each retrieval from the cache increases the ref count and each close on the shared resource decreases the ref count. Assuming the user uses try-resources, this should fix all the issues above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation had multiple issues. First, the reference counting was exposed to the user, and surprise, it was not used correctly. Second, with correct reference counting, the cache did not evict unused resources but instead returned also already closed resources. And last, even if both issues are fixed, the reference count needs to be performed atomically with the cache eviction, which is not really possible with guava.
This patch tries to keep track of shared resources transparently. Each retrieval from the cache increases the ref count and each close on the shared resource decreases the ref count. Assuming the user uses try-resources, this should fix all the issues above.