Optimize StringBuilder#append (apache#4872)

Author: thelproad

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java

@@ -56,13 +56,9 @@ public Status check() {
                 if (msg.length() > 0) {
                     msg.append(";");
                 }
-                msg.append("Pool status:" + lvl
-                        + ", max:" + tp.getMaximumPoolSize()
-                        + ", core:" + tp.getCorePoolSize()
-                        + ", largest:" + tp.getLargestPoolSize()
-                        + ", active:" + tp.getActiveCount()
-                        + ", task:" + tp.getTaskCount()
-                        + ", service port: " + port);
+                msg.append("Pool status:").append(lvl).append(", max:").append(tp.getMaximumPoolSize()).append(", core:")
+                        .append(tp.getCorePoolSize()).append(", largest:").append(tp.getLargestPoolSize()).append(", active:")
+                        .append(tp.getActiveCount()).append(", task:").append(tp.getTaskCount()).append(", service port: ").append(port);
             }
         }
         return msg.length() == 0 ? new Status(Status.Level.UNKNOWN) : new Status(level, msg.toString());

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java

@@ -41,7 +41,7 @@ public String telnet(Channel channel, String message) {
         if ("/".equals(message) || "..".equals(message)) {
             String service = (String) channel.getAttribute(SERVICE_KEY);
             channel.removeAttribute(SERVICE_KEY);
-            buf.append("Cancelled default service " + service + ".");
+            buf.append("Cancelled default service ").append(service).append(".");
         } else {
             boolean found = false;
             for (Exporter<?> exporter : DubboProtocol.getDubboProtocol().getExporters()) {
@@ -54,9 +54,9 @@ public String telnet(Channel channel, String message) {
             }
             if (found) {
                 channel.setAttribute(SERVICE_KEY, message);
-                buf.append("Used the " + message + " as default.\r\nYou can cancel default service by command: cd /");
+                buf.append("Used the ").append(message).append(" as default.\r\nYou can cancel default service by command: cd /");
             } else {
-                buf.append("No such service " + message);
+                buf.append("No such service ").append(message);
             }
         }
         return buf.toString();

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java

@@ -49,7 +49,7 @@ public String telnet(final Channel channel, String message) {
         }
         StringBuilder buf = new StringBuilder();
         if (service != null && service.length() > 0) {
-            buf.append("Use default service " + service + ".\r\n");
+            buf.append("Use default service ").append(service).append(".\r\n");
         }
         String[] parts = message.split("\\s+");
         String method;
@@ -112,7 +112,7 @@ public void run() {
                 thread.start();
             }
         } else {
-            buf.append("No such service " + service);
+            buf.append("No such service ").append(service);
         }
         return buf.toString();
     }

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java

@@ -237,7 +237,7 @@ private void printSelectMessage(StringBuilder buf, List<Method> methods) {
         buf.append("Methods:\r\n");
         for (int i = 0; i < methods.size(); i++) {
             Method method = methods.get(i);
-            buf.append((i + 1) + ". " + method.getName() + "(");
+            buf.append(i + 1).append(". ").append(method.getName()).append("(");
             Class<?>[] parameterTypes = method.getParameterTypes();
             for (int n = 0; n < parameterTypes.length; n++) {
                 buf.append(parameterTypes[n].getSimpleName());

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java

@@ -70,11 +70,11 @@ public String telnet(Channel channel, String message) {
                         bb.flip();
                         String content = new String(bb.array()).replace("<", "&lt;")
                                 .replace(">", "&gt;").replace("\n", "<br/><br/>");
-                        buf.append("\r\ncontent:" + content);
+                        buf.append("\r\ncontent:").append(content);
 
-                        buf.append("\r\nmodified:" + (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
-                                .format(new Date(file.lastModified()))));
-                        buf.append("\r\nsize:" + size + "\r\n");
+                        buf.append("\r\nmodified:").append(new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
+                                .format(new Date(file.lastModified())));
+                        buf.append("\r\nsize:").append(size).append("\r\n");
                     } catch (Exception e) {
                         buf.append(e.getMessage());
                     }
@@ -84,8 +84,8 @@ public String telnet(Channel channel, String message) {
                 }
             }
         }
-        buf.append("\r\nCURRENT LOG LEVEL:" + LoggerFactory.getLevel())
-                .append("\r\nCURRENT LOG APPENDER:" + (file == null ? "console" : file.getAbsolutePath()));
+        buf.append("\r\nCURRENT LOG LEVEL:").append(LoggerFactory.getLevel()).append("\r\nCURRENT LOG APPENDER:")
+                .append(file == null ? "console" : file.getAbsolutePath());
         return buf.toString();
     }
 

dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java

@@ -58,7 +58,7 @@ public String telnet(Channel channel, String message) {
                     buf.append("\r\n");
                 }
                 if (detail) {
-                    buf.append(server.getUrl().getProtocol() + "://" + server.getUrl().getAddress());
+                    buf.append(server.getUrl().getProtocol()).append("://").append(server.getUrl().getAddress());
                 } else {
                     buf.append(server.getUrl().getPort());
                 }
@@ -79,13 +79,13 @@ public String telnet(Channel channel, String message) {
                         buf.append("\r\n");
                     }
                     if (detail) {
-                        buf.append(c.getRemoteAddress() + " -> " + c.getLocalAddress());
+                        buf.append(c.getRemoteAddress()).append(" -> ").append(c.getLocalAddress());
                     } else {
                         buf.append(c.getRemoteAddress());
                     }
                 }
             } else {
-                buf.append("No such port " + port);
+                buf.append("No such port ").append(port);
             }
         }
         return buf.toString();