Skip to content

Feature flag for flate2 on ratchet-deflate #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntc opened this issue Jan 12, 2025 · 2 comments
Open

Feature flag for flate2 on ratchet-deflate #58

huntc opened this issue Jan 12, 2025 · 2 comments

Comments

@huntc
Copy link

huntc commented Jan 12, 2025

Thanks again for this crate.

I'm attempting a cross build and note that the ratchet-deflate package specifically enables zlib as a feature flag on flate2.

Is there a specific reason for enabling the zlib flag, thus requiring C compilation? Would you consider a PR to feature-flag enabling ratchet-deflate to accept flate2's rust_backend feature in addition to a zlib feature that could be the default?

@huntc
Copy link
Author

huntc commented Jan 15, 2025

It turns out that zlib is actually a requirement given the use of window bits. Closing.

@huntc huntc closed this as completed Jan 15, 2025
@huntc huntc reopened this Mar 30, 2025
@huntc
Copy link
Author

huntc commented Mar 30, 2025

Reopening if I may. It appears that there is support for zlib-rs via its C API (rust-lang/flate2-rs#400). Thus we should be able to support the zlib-rs feature flag with this crate. Do you see an issue with that? Window bits are supported… Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant