chore: stronger typing for xast/css-select code #2112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves type checking for
lib/svgo/css-select-adapter.js
. Before, we declared an explicitany
over the options.querySelector
andquerySelectorAll
in our.d.ts
file. Instead, we use a JSDoc type, and export that in our.d.ts
. This achieves the same result, but we maintain the type with the implementation, leaving less risk for it to fall out of sync.lib/svgo/css-select-adapter.d.ts
and uses the upstream types when we define our config. (I did declareany
for two functions as they were annoying to resolve, I will look at this in future. Again, I'm striving for better, not perfect.)