Skip to content

Commit 9b50292

Browse files
ipfipf
committed
Add Attributes for Tests
1 parent 71853f0 commit 9b50292

10 files changed

+44
-84
lines changed

‎Tests/Unit/Controller/SearchControllerTest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
* This copyright notice MUST APPEAR in all copies of the script!
2828
* ************************************************************* */
2929

30+
use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
31+
use PHPUnit\Framework\Attributes\Test;
3032
use Subugoe\Find\Controller\SearchController;
3133
use TYPO3\TestingFramework\Core\BaseTestCase;
3234

@@ -47,11 +49,8 @@ protected function setUp(): void
4749
->getMock();
4850
}
4951

50-
/**
51-
* @test
52-
*
53-
* @doesNotPerformAssertions
54-
*/
52+
#[Test]
53+
#[DoesNotPerformAssertions]
5554
public function implementTests(): void
5655
{
5756
self::markTestIncomplete();

‎Tests/Unit/Service/SolrServiceProviderTest.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
* This copyright notice MUST APPEAR in all copies of the script!
2828
* ************************************************************* */
2929

30+
use PHPUnit\Framework\Attributes\Test;
3031
use Subugoe\Find\Service\SolrServiceProvider;
3132
use TYPO3\TestingFramework\Core\BaseTestCase;
3233

@@ -42,15 +43,10 @@ class SolrServiceProviderTest extends BaseTestCase
4243

4344
protected function setUp(): void
4445
{
45-
$this->fixture = $this->getMockBuilder(SolrServiceProvider::class)
46-
->addMethods(['dummy'])
47-
->disableOriginalConstructor()
48-
->getMock();
46+
$this->fixture = $this->getAccessibleMock(SolrServiceProvider::class, null, callOriginalConstructor: false);
4947
}
5048

51-
/**
52-
* @test
53-
*/
49+
#[Test]
5450
public function setConfigurationAddsTheValueToConfigurationArray()
5551
{
5652
$key = 'foo';
@@ -60,9 +56,7 @@ public function setConfigurationAddsTheValueToConfigurationArray()
6056
self::assertArrayHasKey($key, $this->fixture->getConfiguration());
6157
}
6258

63-
/**
64-
* @test
65-
*/
59+
#[Test]
6660
public function setConfigurationAddsAKeyValuePairToAnExistingConfiguration()
6761
{
6862
$key = 'foo';

‎Tests/Unit/Utility/UpgradeUtilityTest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@
44

55
namespace Subugoe\Find\Tests\Unit\Utility;
66

7+
use PHPUnit\Framework\Attributes\DataProvider;
8+
use PHPUnit\Framework\Attributes\Test;
79
use Subugoe\Find\Utility\UpgradeUtility;
810
use TYPO3\TestingFramework\Core\BaseTestCase;
911

1012
class UpgradeUtilityTest extends BaseTestCase
1113
{
12-
public function settingsProvider(): array
14+
public static function settingsProvider(): array
1315
{
1416
return [
1517
[
@@ -61,11 +63,8 @@ public function settingsProvider(): array
6163
];
6264
}
6365

64-
/**
65-
* @test
66-
*
67-
* @dataProvider settingsProvider
68-
*/
66+
#[DataProvider('settingsProvider')]
67+
#[Test]
6968
public function configurationIsAutomaticallyUpgraded(array $settings, $expected): void
7069
{
7170
self::assertSame($expected, UpgradeUtility::handleSolariumUpgrade($settings));

‎Tests/Unit/ViewHelpers/Data/NewArrayViewHelperTest.php

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use PHPUnit\Framework\MockObject\MockObject;
3031
use Subugoe\Find\ViewHelpers\Data\NewArrayViewHelper;
3132
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -48,9 +49,7 @@ protected function setUp(): void
4849
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
4950
}
5051

51-
/**
52-
* @test
53-
*/
52+
#[Test]
5453
public function aNewArrayFromArgumentsIsCorrectlyCreated(): void
5554
{
5655
$arguments = [
@@ -70,9 +69,7 @@ public function aNewArrayFromArgumentsIsCorrectlyCreated(): void
7069
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
7170
}
7271

73-
/**
74-
* @test
75-
*/
72+
#[Test]
7673
public function aNewArrayWithoutAnExistingOneIsCreated(): void
7774
{
7875
$arguments = [
@@ -90,9 +87,7 @@ public function aNewArrayWithoutAnExistingOneIsCreated(): void
9087
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
9188
}
9289

93-
/**
94-
* @test
95-
*/
90+
#[Test]
9691
public function aNewArrayWithMultipleEntriesIsCreated(): void
9792
{
9893
$arguments = [
@@ -111,9 +106,7 @@ public function aNewArrayWithMultipleEntriesIsCreated(): void
111106
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
112107
}
113108

114-
/**
115-
* @test
116-
*/
109+
#[Test]
117110
public function emptyStringsAsArrayKeysAreConsideredAsKeysAndValues(): void
118111
{
119112
$arguments = [

‎Tests/Unit/ViewHelpers/Data/SplitViewHelperTest.php

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use Subugoe\Find\ViewHelpers\Data\SplitViewHelper;
3031
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
3132
use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -48,9 +49,7 @@ protected function setUp(): void
4849
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
4950
}
5051

51-
/**
52-
* @test
53-
*/
52+
#[Test]
5453
public function stringIsExplodedCorrectlyWithoutPassedSeparator()
5554
{
5655
$string = 'hrdr, behedeti, horus';
@@ -64,9 +63,7 @@ public function stringIsExplodedCorrectlyWithoutPassedSeparator()
6463
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
6564
}
6665

67-
/**
68-
* @test
69-
*/
66+
#[Test]
7067
public function stringIsExplodedCorrectlyWithPassedSeparator()
7168
{
7269
$string = 'hrdr, behedeti, horus';
@@ -81,9 +78,7 @@ public function stringIsExplodedCorrectlyWithPassedSeparator()
8178
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
8279
}
8380

84-
/**
85-
* @test
86-
*/
81+
#[Test]
8782
public function stringIsExplodedCorrectlyWithNonDefaultSeparator()
8883
{
8984
$string = 'hrdrhorus behedetihorus horus';
@@ -97,9 +92,7 @@ public function stringIsExplodedCorrectlyWithNonDefaultSeparator()
9792
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
9893
}
9994

100-
/**
101-
* @test
102-
*/
95+
#[Test]
10396
public function emptyArrayIsReturnedWhenPassingIt()
10497
{
10598
$string = '';

‎Tests/Unit/ViewHelpers/Data/ValueForKeyViewHelperTest.php

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
3031
use Subugoe\Find\ViewHelpers\Data\ValueForKeyViewHelper;
3132
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -51,9 +52,7 @@ protected function setUp(): void
5152
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
5253
}
5354

54-
/**
55-
* @test
56-
*/
55+
#[Test]
5756
public function keyPicksTheRightValueFromTheArray()
5857
{
5958
$array = [
@@ -70,9 +69,7 @@ public function keyPicksTheRightValueFromTheArray()
7069
self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
7170
}
7271

73-
/**
74-
* @test
75-
*/
72+
#[Test]
7673
public function resultIsCorrectlyInterpretedAsJsonFromASimpleValue()
7774
{
7875
$array = [
@@ -90,9 +87,7 @@ public function resultIsCorrectlyInterpretedAsJsonFromASimpleValue()
9087
self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
9188
}
9289

93-
/**
94-
* @test
95-
*/
90+
#[Test]
9691
public function resultIsCorrectlyInterpretedAsTextFromASimpleValue()
9792
{
9893
$array = [
@@ -110,9 +105,7 @@ public function resultIsCorrectlyInterpretedAsTextFromASimpleValue()
110105
self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
111106
}
112107

113-
/**
114-
* @test
115-
*/
108+
#[Test]
116109
public function providingANonexistingKeyReturnsNull()
117110
{
118111
$array = [

‎Tests/Unit/ViewHelpers/Find/FacetIsActiveViewHelperTest.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use Subugoe\Find\ViewHelpers\Find\FacetIsActiveViewHelper;
3031
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
3132
use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -47,9 +48,7 @@ protected function setUp(): void
4748
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
4849
}
4950

50-
/**
51-
* @test
52-
*/
51+
#[Test]
5352
public function activeFacetIsCorrectlyRecognized()
5453
{
5554
$arguments = [
@@ -75,9 +74,7 @@ public function activeFacetIsCorrectlyRecognized()
7574
self::assertTrue($this->fixture->initializeArgumentsAndRender());
7675
}
7776

78-
/**
79-
* @test
80-
*/
77+
#[Test]
8178
public function notActiveFacetsReturnFalse()
8279
{
8380
$arguments = [

‎Tests/Unit/ViewHelpers/Find/FacetLinkArgumentsViewHelperTest.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
3031
use Subugoe\Find\ViewHelpers\Find\FacetLinkArgumentsViewHelper;
3132
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -50,9 +51,7 @@ protected function setUp(): void
5051
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
5152
}
5253

53-
/**
54-
* @test
55-
*/
54+
#[Test]
5655
public function filterIsCorrectlyRemovedOnTextQueries()
5756
{
5857
$this->fixture->setArguments([
@@ -66,9 +65,7 @@ public function filterIsCorrectlyRemovedOnTextQueries()
6665
self::assertEquals('tx_find_find[facet][title]', $result[0]);
6766
}
6867

69-
/**
70-
* @test
71-
*/
68+
#[Test]
7269
public function filterIsCorrectlyAddedOnTextQueries()
7370
{
7471
$this->fixture->setArguments([

‎Tests/Unit/ViewHelpers/Find/HighlightFieldViewHelperTest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
30+
use PHPUnit\Framework\Attributes\Test;
2931
use Subugoe\Find\ViewHelpers\Find\HighlightFieldViewHelper;
3032
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
3133
use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -52,11 +54,8 @@ protected function setUp(): void
5254
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
5355
}
5456

55-
/**
56-
* @test
57-
*
58-
* @doesNotPerformAssertions
59-
*/
57+
#[Test]
58+
#[DoesNotPerformAssertions]
6059
public function fieldIsCorrectlyHighlighted()
6160
{
6261
self::markTestIncomplete('Still something to do with mocking solarium');

‎Tests/Unit/ViewHelpers/Find/PageNumberForResultNumberViewHelperTest.php

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* This copyright notice MUST APPEAR in all copies of the script!
2727
* ************************************************************* */
2828

29+
use PHPUnit\Framework\Attributes\Test;
2930
use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
3031
use Subugoe\Find\ViewHelpers\Find\PageNumberForResultNumberViewHelper;
3132
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -51,9 +52,7 @@ protected function setUp(): void
5152
$this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
5253
}
5354

54-
/**
55-
* @test
56-
*/
55+
#[Test]
5756
public function pageNumberIsCorrectlyCalculated()
5857
{
5958
$resultNumber = 55;
@@ -68,9 +67,7 @@ public function pageNumberIsCorrectlyCalculated()
6867
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
6968
}
7069

71-
/**
72-
* @test
73-
*/
70+
#[Test]
7471
public function pageNumerWhenResultIsZero()
7572
{
7673
$resultNumber = 0;
@@ -86,9 +83,7 @@ public function pageNumerWhenResultIsZero()
8683
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
8784
}
8885

89-
/**
90-
* @test
91-
*/
86+
#[Test]
9287
public function divisionByZeroIsCaught()
9388
{
9489
$resultNumber = 0;
@@ -103,7 +98,8 @@ public function divisionByZeroIsCaught()
10398
self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
10499
}
105100

106-
public function pageNumberFallBackForZeroResultsPerPage()
101+
#[Test]
102+
public function pageNumberFallBackForZeroResultsPerPage(): void
107103
{
108104
$resultNumber = 55;
109105
$resultsPerPage = 0;

0 commit comments

Comments
 (0)