-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Describe the bug
I am in the process of updating my custom code generators to Entitas 1.14 and encountered the following bug.
When using dotnet Jenny/Jenny.Generator.Cli.dll wiz
the Assets\Entitas
of SearchPaths line is automatically removed, resulting in errors when generating
To Reproduce
Steps to reproduce the behavior:
- Add a custom code generator
- Use
dotnet Jenny/Jenny.Generator.Cli.dll wiz
to scan for the new generator - Add the new generator and finish the dry run
- The
Assets\Entitas
line is now missing - Generating results in an error stating the Entitas assembly could not be found, as expected by the removal of the SearchPath
Expected behavior
Do not remove valid SearchPaths
When diving through the jenny code I assume this part is responsible for doing this:
https://github.com/sschmid/Jenny/blob/518529e6dd1f33b816cb30ab216b98c44c07f0dc/src/Jenny.Generator.Cli/FixCommand.cs#L85
As this path technically only contains dependencies and no active plugins, it is seen as unused and removed.
I can offer to create a pull request to jenny, but want to clear beforehand if the following method would be a suitable fix:
- Add a new property to the Jenny.properties file called Jenny.DependencyPaths
- Do not autoremove lines from that property on calling the fix function
- Merge DependencyPaths and SearchPaths on execution
Metadata
Metadata
Assignees
Labels
Projects
Status
Activity