fix: fix integration tests local (#97)

* Still need to figure out the ATA creation, de-hardcode recipient #2

* Ata creation done, all common function in utils, some cleanup + update doc

* Updated readme + claude based on pr comments

Author: dev-jodee

CLAUDE.md

@@ -52,13 +52,69 @@ make lint-fix-all
 # Run unit tests
 make test
 
+# Setup test environment (for integration tests)
+make setup-test-env
+
 # Run integration tests
 make test-integration
 
 # Run all tests
 cargo test --workspace
 ```
 
+#### Integration Test Environment Setup
+
+Integration tests require a local validator and test account setup:
+
+1. **Start local validator:**
+   ```bash
+   solana-test-validator --reset --quiet
+   ```
+
+2. **Start local Kora Server:**
+    ```bash
+    make run
+    ```
+
+3. **Run integration tests:**
+   ```bash
+   make test-integration
+   ```
+    This will initialize a test environment (cargo run -p tests --bin setup-test-env):
+   - Verify test validator is running
+   - Create and fund test accounts
+   - Set up USDC mint and token accounts
+   - Display account summary
+
+   And run all integration tests (cargo test --test integration)
+
+#### Customize Test Environment
+
+The test suite uses environment variables for configuration (checked before falling back to defaults):
+
+| Variable | Description | Default |
+|----------|-------------|---------|
+| `RPC_URL` | Solana RPC endpoint | `http://127.0.0.1:8899` |
+| `TEST_SERVER_URL` | Kora RPC server URL | `http://127.0.0.1:8080` |
+| `TEST_SENDER_KEYPAIR` | Base58 encoded test sender keypair | Built-in test keypair |
+| `TEST_RECIPIENT_PUBKEY` | Test recipient public key | Built-in test pubkey |
+| `KORA_PRIVATE_KEY` | Kora fee payer private key | Built-in test keypair |
+| `TEST_USDC_MINT_KEYPAIR` | Test USDC mint keypair | Built-in test mint |
+| `TEST_USDC_MINT_DECIMALS` | USDC mint decimals | `6` |
+
+Make sure to update kora.toml to reflect the public key of TEST_USDC_MINT_KEYPAIR.
+
+**Example with custom test configuration:**
+```bash
+# Create .env file for custom test setup
+echo "RPC_URL=https://api.devnet.solana.com" > .env
+echo "TEST_SENDER_KEYPAIR=your_base58_keypair" >> .env
+echo "KORA_PRIVATE_KEY=your_fee_payer_keypair" >> .env
+
+# Run tests with custom config
+make test-integration
+```
+
 ### Running Services
 
 ```bash

Makefile

@@ -1,4 +1,4 @@
-.PHONY: check fmt lint test build run clean all regen-tk fix-all generate-ts-client
+.PHONY: check fmt lint test build run clean all regen-tk fix-all generate-ts-client setup-test-env test-integration
 
 # Default target
 all: check test build
@@ -27,8 +27,13 @@ lint:
 test:
 	cargo test --lib
 
+# Setup test environment
+setup-test-env:
+	cargo run -p tests --bin setup-test-env
+
 # Run integration tests
 test-integration:
+	cargo run -p tests --bin setup-test-env
 	cargo test --test integration
 
 # Build all binaries

README.md

@@ -418,8 +418,63 @@ make build
 # Run all tests
 make test
 
+# Setup test environment (for integration tests)
+make setup-test-env
+
 # Run integration tests
-make test-integrations
+make test-integration
+```
+
+#### Integration Test Environment Setup
+
+Integration tests require additional setup for test accounts and local validator:
+
+1. **Start local validator:**
+   ```bash
+   solana-test-validator --reset
+   ```
+
+2. **Start local Kora Server:**
+    ```bash
+    make run
+    ```
+
+3. **Run integration tests:**
+   ```bash
+   make test-integration
+   ```
+    This will initialize a test environment (cargo run -p tests --bin setup-test-env):
+   - Verify test validator is running
+   - Create and fund test accounts
+   - Set up USDC mint and token accounts
+   - Display account summary
+
+   And run all integration tests (cargo test --test integration)
+
+#### Customize Test Environment
+
+You can customize test behavior by setting environment variables:
+
+| Variable | Description | Default |
+|----------|-------------|---------|
+| `RPC_URL` | Solana RPC endpoint | `http://127.0.0.1:8899` |
+| `TEST_SERVER_URL` | Kora RPC server URL | `http://127.0.0.1:8080` |
+| `TEST_SENDER_KEYPAIR` | Base58 encoded test sender keypair | Built-in test keypair |
+| `TEST_RECIPIENT_PUBKEY` | Test recipient public key | Built-in test pubkey |
+| `KORA_PRIVATE_KEY` | Kora fee payer private key | Built-in test keypair |
+| `TEST_USDC_MINT_KEYPAIR` | Test USDC mint keypair | Built-in test mint |
+| `TEST_USDC_MINT_DECIMALS` | USDC mint decimals | `6` |
+
+Make sure to update kora.toml to reflect the public key of TEST_USDC_MINT_KEYPAIR.
+
+**Example with custom environment:**
+```bash
+# Create .env file
+echo "RPC_URL=https://api.devnet.solana.com" > .env
+echo "TEST_SENDER_KEYPAIR=your_base58_keypair" >> .env
+
+# Run tests
+make test-integration
 ```
 
 ### Running

crates/lib/src/token/token22.rs

@@ -1,6 +1,6 @@
 use super::interface::{TokenInterface, TokenState};
 use async_trait::async_trait;
-use solana_program::{program_pack::Pack, pubkey::Pubkey};
+use solana_program::pubkey::Pubkey;
 use solana_sdk::instruction::Instruction;
 use spl_associated_token_account::{
     get_associated_token_address_with_program_id, instruction::create_associated_token_account,

crates/lib/src/transaction/validator.rs

@@ -163,6 +163,7 @@ impl TransactionValidator {
         Ok(())
     }
 
+    #[allow(dead_code)]
     fn validate_fee_payer_usage(&self, message: &Message) -> Result<(), KoraError> {
         // Check if fee payer is first account
         if message.account_keys.first() != Some(&self.fee_payer_pubkey) {

kora.toml

@@ -6,14 +6,14 @@ max_allowed_lamports = 1000000
 max_signatures = 10
 price_source = "Mock"
 allowed_programs = [
-    "11111111111111111111111111111111",  # System Program
+    "11111111111111111111111111111111",             # System Program
     "TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA",  # Token Program
     "ATokenGPvbdGVxr1b2hvZbsiqW5xWH25efTNsLJA8knL",
 ]
 allowed_tokens = [
-    "4zMMC9srt5Ri5X14GAgXhaHii3GnPAEERYPJgZJDncDU",  # USDC devnet
+    "9BgeTKqmFsPVnfYscfM6NvsgmZxei7XfdciShQ6D3bxJ", # Test USDC mint for local testing
 ]
 allowed_spl_paid_tokens = [
-    "4zMMC9srt5Ri5X14GAgXhaHii3GnPAEERYPJgZJDncDU",  # USDC devnet
-] 
-disallowed_accounts = []
+    "9BgeTKqmFsPVnfYscfM6NvsgmZxei7XfdciShQ6D3bxJ", # Test USDC mint for local testing
+]
+disallowed_accounts = []

tests/Cargo.toml

@@ -15,6 +15,10 @@ path = "api_integration_tests.rs"
 name = "token_integration"
 path = "token_integration_tests.rs"
 
+[[bin]]
+name = "setup-test-env"
+path = "setup-test-env.rs"
+
 [dependencies]
 kora-lib = { path = "../crates/lib" }
 solana-sdk = { workspace = true }
@@ -28,4 +32,5 @@ dotenv = { workspace = true }
 jsonrpsee = { workspace = true }
 serde_json = { workspace = true }
 tokio = { workspace = true }
-hex = { workspace = true } 
+hex = { workspace = true }
+testing-utils = { path = "testing-utils" }